Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default variables in release #4124

Merged
merged 2 commits into from
Apr 11, 2022
Merged

change default variables in release #4124

merged 2 commits into from
Apr 11, 2022

Conversation

HarrisChu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

  1. there're too many variables when building release package, and when we build nebula in test platform, we should follow these options.
  2. just use package.sh directly when building release.

@HarrisChu HarrisChu requested review from Shylock-Hg and yixinglu April 8, 2022 05:42
@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Apr 8, 2022
yixinglu
yixinglu approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 0fbe9f5 into vesoft-inc:master Apr 11, 2022
@HarrisChu HarrisChu deleted the enhance_package branch April 11, 2022 10:32
@jamieliu1023 jamieliu1023 mentioned this pull request Apr 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango approved these changes

@yixinglu yixinglu yixinglu approved these changes

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarrisChu @yixinglu @czpmango