Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Atomic Edge #4127

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Conversation

liuyu85cn
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@liuyu85cn liuyu85cn added ready-for-testing PR: ready for the CI test ready for review labels Apr 8, 2022
@liuyu85cn liuyu85cn force-pushed the remove_atomic_edge branch from 7d83692 to 72a57f3 Compare April 8, 2022 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #4127 (92715d0) into master (372f6b4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4127      +/-   ##
==========================================
+ Coverage   85.03%   85.06%   +0.03%     
==========================================
  Files        1328     1324       -4     
  Lines      131649   131914     +265     
==========================================
+ Hits       111950   112216     +266     
+ Misses      19699    19698       -1     
Impacted Files Coverage Δ
src/graph/executor/admin/SpaceExecutor.cpp 77.14% <ø> (-0.33%) ⬇️
src/graph/planner/match/MatchClausePlanner.h 100.00% <ø> (ø)
src/graph/planner/match/MatchClausePlanner.cpp 98.78% <100.00%> (+0.12%) ⬆️
src/graph/validator/MatchValidator.cpp 88.13% <100.00%> (+0.50%) ⬆️
src/common/thread/test/GenericWorkerTest.cpp 54.16% <0.00%> (-44.45%) ⬇️
src/meta/test/MockHdfsHelper.h 37.50% <0.00%> (-43.75%) ⬇️
src/common/thread/GenericThreadPool.h 56.25% <0.00%> (-43.75%) ⬇️
src/common/thread/test/GenericThreadPoolTest.cpp 53.42% <0.00%> (-30.14%) ⬇️
src/kvstore/raftex/RaftexService.h 75.00% <0.00%> (-25.00%) ⬇️
src/storage/admin/AdminTask.cpp 64.51% <0.00%> (-15.49%) ⬇️
... and 365 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08004a...92715d0. Read the comment docs.

yixinglu
yixinglu previously approved these changes Apr 11, 2022
@HarrisChu HarrisChu added the doc affected PR: improvements or additions to documentation label Apr 11, 2022
@HarrisChu
Copy link
Contributor

@critical27 critical27 added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 13, 2022
@Sophie-Xie Sophie-Xie merged commit 49113e3 into vesoft-inc:master Apr 13, 2022
Sophie-Xie pushed a commit that referenced this pull request Apr 13, 2022
* try to remove Atomic Edge

* remove some space

* remove zone

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
@critical27 critical27 deleted the remove_atomic_edge branch April 13, 2022 09:04
Sophie-Xie added a commit that referenced this pull request Apr 13, 2022
* Add SetUsageMessage For daemons (#4134)

* fix the wrong regex pattern of scientific notation (#4136)

* fix updatePart (#4139)

* fix updatePart

* fix format check

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* show DATA_BALANCE in job list (#4138)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix disk fault recovery (#4131)

* fix disk fault recovery

* add ut

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Refactor findpath (#4095)

* optimize bfs

* optimizer allpath

* optimizer multi-shortestpath

* optimizer multi shortest path

* fix validate unit test

* add some comment

* fix error

* fix bfs error

* add comment

* delete conjunct

* add findpath unit test

* delete useless file

* delete log

* remove check

* multi thread executor

* single shortest multi thread

* add some testcases

* add gflags

* fix bfs error

* address comment

* Just report errorof property pruner in debug mode (#4142)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* remove Atomic Edge (#4127)

* try to remove Atomic Edge

* remove some space

* remove zone

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* fix show tag/edge index status (#4148)

* fix multiple match (#4143)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Refactor the process of symbols in optimizer. (#4146)

* Refactor the process of symbols in optimizer.

* Fix variable shadowing.

* Collect boundary from MatchResult directly.

* Check variable in TransformResult don't referenced by outside plan
nodes.

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
@Sophie-Xie Sophie-Xie linked an issue Apr 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete Atomic Edge in desc space
7 participants