Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show DATA_BALANCE in job list #4138

Merged
merged 3 commits into from
Apr 12, 2022
Merged

show DATA_BALANCE in job list #4138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
411763a
show DATA_BALANCE in job list
liwenhui-soul Apr 12, 2022
ef8b3a3
Merge branch 'master' into lwh
Sophie-Xie Apr 12, 2022
74fa378
Merge branch 'master' into lwh
Sophie-Xie Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/graph/executor/admin/SubmitJobExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ nebula::DataSet SubmitJobExecutor::buildShowResultData(
uint32_t total = paras.size() - index - 1, succeeded = 0, failed = 0, inProgress = 0,
invalid = 0;
v.emplace_back(Row({jd.get_job_id(),
apache::thrift::util::enumNameSafe(jd.get_type()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not accurate
The parser file needs to be changed. Introduced by #4119

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser already changed in 4119

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could not be changed, the ZONE_BALNCE type is used in the whole process

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is ZONE_BALNCE？ not DATA_BALANCE？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line 110，Why DATA_BALANCE and ZONE_BALANCE are needed？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one host in one default zone, so the zone balancer could handle it, DATA_BALANCE is balancing in one zone, not suitable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it feels a little weird.
The entered balance data command is executed internally according to zone_balance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, a little, it's a temporary change and will be changed back in future, I think

apache::thrift::util::enumNameSafe(meta::cpp2::JobType::DATA_BALANCE),
apache::thrift::util::enumNameSafe(jd.get_status()),
convertJobTimestampToDateTime(jd.get_start_time()).toString(),
convertJobTimestampToDateTime(jd.get_stop_time()).toString(),
Expand Down