Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/plan compare #4210

Merged
merged 12 commits into from
Apr 27, 2022
Merged

Fix/plan compare #4210

merged 12 commits into from
Apr 27, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Apr 26, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Fix the plan comparing in tck. Support to compare the nested dictionary in plan.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Apr 26, 2022
jievince
jievince previously approved these changes Apr 26, 2022
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks for fixing it.

Aiee
Aiee previously approved these changes Apr 26, 2022
tests/common/plan_differ.py Outdated Show resolved Hide resolved
tests/common/plan_differ.py Show resolved Hide resolved
nevermore3
nevermore3 previously approved these changes Apr 26, 2022
@Shylock-Hg Shylock-Hg dismissed stale reviews from nevermore3, Aiee, and jievince via b62bcc1 April 26, 2022 11:14
@Shinji-IkariG Shinji-IkariG merged commit c56e302 into vesoft-inc:master Apr 27, 2022
@Shylock-Hg Shylock-Hg deleted the fix/plan-compare branch April 27, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants