Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subgraph filter #4357

Merged
merged 13 commits into from
Oct 1, 2022
Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Jun 27, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

support vertex filter & edge filter in subgraph sentence

1、subgraph operator consists of the getNeighbors operator, which loops the user-specified number of times inside the subgraph operator.
2、where clause does not support logicalOR expressions, bcz $^.player.age > 30 OR like.likeness > 80 can't filter data only by $^.player.age
3、for the VID that does not satisfy the tagfilter condition, the filterEdge function will filter the edge where dst is VID in the previous step

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the subgraph_vertices_filter branch 5 times, most recently from b6d82a0 to 769699b Compare July 4, 2022 08:58
@nevermore3 nevermore3 force-pushed the subgraph_vertices_filter branch 2 times, most recently from 114708a to 3d6a2ee Compare July 6, 2022 03:30
@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Jul 18, 2022
@nevermore3 nevermore3 force-pushed the subgraph_vertices_filter branch 2 times, most recently from d4f2524 to beed8aa Compare September 16, 2022 01:59
@nevermore3
Copy link
Contributor Author

waiting #4649 fix

@nevermore3 nevermore3 mentioned this pull request Sep 26, 2022
11 tasks
@nevermore3 nevermore3 marked this pull request as ready for review September 29, 2022 03:16
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Sep 29, 2022
@nevermore3 nevermore3 requested a review from a team as a code owner September 30, 2022 08:07
@nevermore3 nevermore3 added doc affected PR: improvements or additions to documentation ready for review labels Sep 30, 2022
@Sophie-Xie Sophie-Xie merged commit d67cc4b into vesoft-inc:master Oct 1, 2022
@nevermore3 nevermore3 deleted the subgraph_vertices_filter branch October 1, 2022 05:32
@foesa-yang foesa-yang self-requested a review October 8, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants