Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect result of optional match statement #4670

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Sep 22, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4168

How do you solve it?

The fix is complex and may require refactoring the code related to how the execution plan was generated.
Give the user an error message for now.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango changed the title fix optional match Fix incorrect result of optional match statement Sep 22, 2022
@czpmango czpmango requested review from Shylock-Hg and Aiee September 22, 2022 06:24
@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Sep 23, 2022

Can we resolve it by apply filter later?

@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Sep 23, 2022
@codesigner
Copy link
Contributor

LGTM

@Sophie-Xie Sophie-Xie merged commit 450e58e into vesoft-inc:master Sep 23, 2022
@czpmango
Copy link
Contributor Author

Can we resolve it by apply filter later?

The current implementation is to apply filter after the left join, which is the crux of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants