-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix job manager ut in asan #4678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
commented
Sep 26, 2022
panda-sheep
requested review from
cangfengzhs,
pengweisong,
SuperYoko and
wenhaocs
and removed request for
liwenhui-soul
September 26, 2022 08:35
liwenhui-soul
previously approved these changes
Sep 26, 2022
SuperYoko
reviewed
Sep 26, 2022
SuperYoko
previously approved these changes
Sep 26, 2022
critical27
reviewed
Sep 26, 2022
panda-sheep
dismissed stale reviews from SuperYoko and liwenhui-soul
via
September 26, 2022 10:43
c5c11a4
panda-sheep
force-pushed
the
fix_job_ut_in_assn
branch
from
September 27, 2022 02:43
3336c66
to
3b6acb3
Compare
SuperYoko
approved these changes
Sep 27, 2022
10 tasks
critical27
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
fix error in job manager UT in ASAN
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: