Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restart if the process is stopped #4849

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

HarrisChu
Copy link
Contributor

if the process is already stopped, [[ ${VERBOSE} -ne 0 ]] && INFO "No such process" will return not zero without -v

so just ignore the code

@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Nov 10, 2022
critical27
critical27 previously approved these changes Nov 17, 2022
Aiee
Aiee previously approved these changes Nov 17, 2022
yixinglu
yixinglu previously approved these changes Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.56% // Head: 76.97% // Decreases project coverage by -7.58% ⚠️

Coverage data is based on head (d4416ae) compared to base (63a63ac).
Patch coverage: 85.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
- Coverage   84.56%   76.97%   -7.59%     
==========================================
  Files        1358     1110     -248     
  Lines      136387    82149   -54238     
==========================================
- Hits       115331    63237   -52094     
+ Misses      21056    18912    -2144     
Impacted Files Coverage Δ
src/graph/executor/admin/SubmitJobExecutor.cpp 56.94% <ø> (+0.78%) ⬆️
src/kvstore/Listener.h 39.13% <ø> (ø)
src/kvstore/Part.h 100.00% <ø> (ø)
src/kvstore/raftex/RaftPart.h 100.00% <ø> (ø)
src/kvstore/wal/FileBasedWal.h 100.00% <ø> (ø)
src/graph/visitor/VidExtractVisitor.cpp 48.83% <50.00%> (-0.15%) ⬇️
src/storage/exec/UpdateNode.h 79.85% <50.00%> (ø)
src/kvstore/Listener.cpp 79.39% <67.34%> (+0.86%) ⬆️
src/graph/service/PermissionManager.cpp 65.13% <75.00%> (ø)
src/graph/util/ExpressionUtils.cpp 94.76% <93.75%> (-0.11%) ⬇️
... and 309 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 5bf34d7 into vesoft-inc:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants