Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify time format in show job #4872

Merged
merged 1 commit into from
Nov 15, 2022
Merged

unify time format in show job #4872

merged 1 commit into from
Nov 15, 2022

Conversation

SuperYoko
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/1553

Description:

As you can see, time show in this table is not in the same format, since a toString() method, I unify them to version without toString, so that it can look the same.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Nov 14, 2022
@critical27 critical27 merged commit a5c08a6 into vesoft-inc:master Nov 15, 2022
@foesa-yang foesa-yang self-assigned this Jan 17, 2023
@foesa-yang foesa-yang added the doc affected PR: improvements or additions to documentation label Jan 17, 2023
@foesa-yang
Copy link

@SuperYoko SuperYoko deleted the reorg_timeshow branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants