Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct covarage #4883

Merged
merged 2 commits into from
Nov 16, 2022
Merged

correct covarage #4883

merged 2 commits into from
Nov 16, 2022

Conversation

cangfengzhs
Copy link
Contributor

  1. exclude /usr/lib
  2. exclude tests
  3. exlucde unit test

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

1. exclude /usr/lib
2. exclude tests
3. exlucde unit test
@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Nov 16, 2022
@Sophie-Xie
Copy link
Contributor

Good job! Can you fix nightly.yml?Thanks.

@xtcyclist
Copy link
Contributor

xtcyclist commented Nov 16, 2022

why excluding tests? oh, I see.

@yixinglu yixinglu merged commit 150e418 into vesoft-inc:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants