Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove job entries when drop space && check space exist when check jo… #4888

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

pengweisong
Copy link
Contributor

@pengweisong pengweisong commented Nov 16, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/1643

Description:

When drop the space, the job entries have not been dropped. Then we create backup, it may have some job entries left which are rebuilding jobs. In this case, there is no rebuilding job really, but the backup creation is blocked.

How do you solve it?

  1. drop the job entries when drop spaces.
  2. skip the spaces not exist when check rebuilding jobs.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@pengweisong pengweisong added the ready-for-testing PR: ready for the CI test label Nov 16, 2022
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.56% // Head: 76.87% // Decreases project coverage by -7.68% ⚠️

Coverage data is based on head (f22de7d) compared to base (63a63ac).
Patch coverage: 83.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4888      +/-   ##
==========================================
- Coverage   84.56%   76.87%   -7.69%     
==========================================
  Files        1358     1102     -256     
  Lines      136387    80980   -55407     
==========================================
- Hits       115331    62254   -53077     
+ Misses      21056    18726    -2330     
Impacted Files Coverage Δ
src/common/datatypes/Value.h 97.05% <ø> (ø)
src/common/function/FunctionManager.cpp 79.32% <ø> (-0.05%) ⬇️
src/graph/executor/StorageAccessExecutor.cpp 83.07% <ø> (-1.65%) ⬇️
src/graph/executor/admin/SubmitJobExecutor.cpp 56.94% <ø> (+0.78%) ⬆️
src/graph/executor/algo/ShortestPathBase.h 50.00% <ø> (ø)
src/graph/service/CloudAuthenticator.cpp 0.00% <0.00%> (ø)
src/graph/util/Utils.h 100.00% <ø> (ø)
src/kvstore/Listener.h 39.13% <ø> (ø)
src/kvstore/Part.h 100.00% <ø> (ø)
src/kvstore/raftex/RaftPart.h 100.00% <ø> (ø)
... and 354 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit ae7e2fe into vesoft-inc:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants