Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ttl not work when ttl column has default value #4961

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Nov 30, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #4962

Description:

As title, the reason is that we only read the ttl property from RowReader, we need to use latest schema as well for data with older schema version.

How do you solve it?

QueryUtils::readValue already handle this.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Add some comments.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

panda-sheep
panda-sheep previously approved these changes Nov 30, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengweisong
Copy link
Contributor

could refer an issue in the community?

@pengweisong
Copy link
Contributor

could refer an issue in the community?

I have fixed it.

@yixinglu yixinglu merged commit 417907f into vesoft-inc:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TTL] when TTL_COL is set to a new field with a default value, the historical data will never expire
6 participants