-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare a doc to help ebable autofdo for nebulagraph #4983
Conversation
@wey-gu Do you want to build a process to generate a profile regularly and provide an option for users to enable the AutoFDO when building from source? |
Oops, Sorry @lipzhu I missed this mention for a month, shame for this. Thanks @xtcyclist @yixinglu btw, what do you guys think of this? |
@wey-gu Its my apologies that delay the document so long. Hope you still have interests about this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this experiment and contribution.
I wonder if there are ways to automate the autofdo build process. After all, we have to integrate it to our standard release workflow.
add_compile_options(-Wnon-virtual-dtor) | ||
add_compile_options(-Woverloaded-virtual) | ||
add_compile_options(-Wignored-qualifiers) | ||
+add_compile_options(-fauto-profile=~/fbdata.afdo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to customize the build with some CMake option rather than such an ad-hoc change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. We can add an default option if the user want to use the default profile provided by community.
And also provide an option to the users who want to build their own profile data based on their real production environment.
My suggestion is to integrate the work into the community standard build workflow, the community refreshed the profile periodically. |
Sorry about the late reply. It takes a lot of effort to integrate this to our build process. But I think the effort is worthy, we will consider to utilize it seriously in the develop plan. Before that, I sugguest we could add this doc to our official docment as an alternative build method, instead of putting it in our source tree. @wey-gu What do you think? |
Wow, looking forward to it!
Agreed, this will enable those who would like to benefit from autofdo before we bring it to the build process. @whitewum what do you think, please? could we somehow put the guide of this PR to docs in a proper chapter and co-author @lipzhu for the docs PR? |
Sure. Great work. I think currently we can add a link in the compile part of the manual to this pr, and mention this is an alternative. |
Cool~ looking forward to the official release version of NebulaGraph with AFDO. |
@dutor I would like to suggest merging this as doc in the core repo as is(or in some other path), now, what do you think, please? |
BTW, @dutor do you mind sharing the performance data about how much afdo can gain from your tests? |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4636
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: