push filter down traverse rule #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
push-filter-into-traverse
branch
4 times, most recently
from
99ca7ba to
80a990c
Compare
jievince
force-pushed
the
push-filter-into-traverse
branch
4 times, most recently
from
bc8e393 to
f672427
Compare
jievince
commented
Dec 6, 2022
Comment on lines
498
to
507
| # When executing query: | ||
| # """ | ||
| # match (:player{name:"Tony Parker"})-[r]->() where exists(r.likeness) return r, exists({a:12}.a) | ||
| # """ | ||
| # Then the result should be, in any order, with relax comparison: | ||
| # | r | exists({a:12}.a) | | ||
| # | [:like "Tony Parker"->"LaMarcus Aldridge" @0 {likeness: 90}] | true | | ||
| # | [:like "Tony Parker"->"Manu Ginobili" @0 {likeness: 95}] | true | | ||
| # | [:like "Tony Parker"->"Tim Duncan" @0 {likeness: 95}] | true | | ||
| When executing query: |
jievince
commented
Dec 6, 2022
Comment on lines
394
to
403
| # When executing query: | ||
| # """ | ||
| # MATCH (:player{name:"Tony Parker"})-[r]->() where exists(r.likeness) return r, exists({a:12}.a) | ||
| # """ | ||
| # Then the result should be, in any order, with relax comparison: | ||
| # | r | exists({a:12}.a) | | ||
| # | [:like "Tony Parker"->"LaMarcus Aldridge" @0 {likeness: 90}] | true | | ||
| # | [:like "Tony Parker"->"Manu Ginobili" @0 {likeness: 95}] | true | | ||
| # | [:like "Tony Parker"->"Tim Duncan" @0 {likeness: 95}] | true | | ||
| When executing query: |
There was a problem hiding this comment.
This PR has merged, could these comment out tests be enabled ?
jievince
commented
Dec 6, 2022
| @@ -24,6 +24,19 @@ PushFilterDownProjectRule::PushFilterDownProjectRule() { | |||
| RuleSet::QueryRules().addRule(this); | |||
| } | |||
|
|
|||
| bool PushFilterDownProjectRule::checkColumnExprKind(const Expression* expr) { | |||
|
|
yixinglu
reviewed
Dec 6, 2022
| static_cast<const Traverse*>(matched.dependencies[0].dependencies[0].node->node()); | ||
| auto step = traverse->stepRange(); | ||
| // step == nullptr means one step. | ||
| return step == nullptr; |
There was a problem hiding this comment.
only support one step tranverse?
There was a problem hiding this comment.
For one step, the query looks like:
match (v1)-[e1]->(v2) where e1.likeness > 78
For multi step, the query should be like:
match (v1)-[e1*1..3]->(v2) where all(i in e1 where i.likeness > 78)
The latter is rarely used currently, so just leave it for future.
Which rule? I don't find it. |
They are not the same rule. |
czpmango
reviewed
Dec 6, 2022
czpmango
reviewed
Dec 6, 2022
| static_cast<const Traverse*>(matched.dependencies[0].dependencies[0].node->node()); | ||
| auto step = traverse->stepRange(); | ||
| // step == nullptr means one step. | ||
| return step == nullptr; |
There was a problem hiding this comment.
bool Traverse::isOneStep() {
return !step;
}
czpmango
reviewed
Dec 6, 2022
| auto* tvGroupNode = matched.dependencies[0].dependencies[0].node; | ||
| auto* tv = static_cast<graph::Traverse*>(tvGroupNode->node()); | ||
| auto& tvColNames = tv->colNames(); | ||
| auto& edgeAlias = tvColNames.back(); |
There was a problem hiding this comment.
Hard code...?
Maybe this:
const auto& Traverse::getEdgeAlias() const {
return colNames_.back();
}
There was a problem hiding this comment.
Hard code...? Maybe this:
const auto& Traverse::getEdgeAlias() const { return colNames.back(); }
Good job
czpmango
reviewed
Dec 6, 2022
| } | ||
|
|
||
| auto* eFilter = tv->eFilter(); | ||
| Expression* newEFilter = nullptr; |
There was a problem hiding this comment.
eFilter?LogicalExpression::makeAnd(pool, newfilterPicked, eFilter->clone()):newFilterPicked;
czpmango
reviewed
Dec 6, 2022
jievince
force-pushed
the
push-filter-into-traverse
branch
from
36c75e2 to
b90e3dd
Compare
jievince
force-pushed
the
push-filter-into-traverse
branch
from
b90e3dd to
a59e35f
Compare
jievince
force-pushed
the
push-filter-into-traverse
branch
from
a59e35f to
78f79aa
Compare
jievince
force-pushed
the
push-filter-into-traverse
branch
from
78f79aa to
db893c8
Compare
czpmango
approved these changes
Dec 6, 2022
yixinglu
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: