Fix label tag expression toString function #5008
Conversation
|
@yixinglu plz fix the error of format. |
yixinglu
force-pushed
the
fix-label-tag-expr-tostring
branch
2 times, most recently
from
3cfa598 to
eb5bbf8
Compare
yixinglu
force-pushed
the
fix-label-tag-expr-tostring
branch
from
eb5bbf8 to
c0fa68f
Compare
| LOG(ERROR) << "Error found in optimization stage for query: " << rctx->query() | ||
| << ", error: " << status.message(); | ||
| return Status::Error( | ||
| "There are some errors found in optimizer, " | ||
| "please contact to the admin to learn more details"); |
There was a problem hiding this comment.
The error message on line 100 is not appropriate, it does not prevent the error message from being passed to the user, and it is more confusing than the original error message.
There was a problem hiding this comment.
Actually, I am not sure what's the better way to handle the optimizer errors. I need to open an issue about this and research how to do that in other db.
| labelStr += "."; | ||
| } | ||
| if (!sym_.empty()) { | ||
| labelStr += sym_ + "."; |
There was a problem hiding this comment.
like the following format?
$-:player.age
$$:player.name
v:player.name
Codecov ReportBase: 77.24% // Head: 77.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5008 +/- ##
==========================================
- Coverage 77.24% 77.23% -0.02%
==========================================
Files 1105 1105
Lines 82054 82081 +27
==========================================
+ Hits 63383 63392 +9
- Misses 18671 18689 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
It's confusing for the following expression string, we should not delete the leading character for all expression.
How do you solve it?
keep the
$character for the$-/$$/$^expressions.In addition, more tests for PushFilterDownHashInnerJoinRule introduced in #4956
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: