User privilege manager in graph layer. #502
Conversation
…moved user property email and phone. 3, Added new user property lock status
|
Can one of the admins verify this patch? |
| #define ACL_ALTERUSER (1<<28) | ||
| #define ACL_GRANT (1<<29) | ||
| #define ACL_REVOKE (1<<30) | ||
| #define ACL_CHANGEPASSWORD (1<<31) |
There was a problem hiding this comment.
I would recommend to use enums.
Besides, you have used up all of the 32 bits, while there are definitely new statements in future. So, You should use a 64bits unsigned integer to represent ACLs instead. BTW. 1 ought to be 1UL.
There was a problem hiding this comment.
enum is better. That makes sense 👍
32 bits is really not enough if a new operation is added，I will change it to 64 bits.
| case RoleType::GOD: | ||
| // God has all privileges | ||
| acl |= (ACL_ADDHOSTS | ||
| |ACL_REMOVEHOSTS |
There was a problem hiding this comment.
There ought to be spaces before and after an operator.
| }, true); | ||
| } | ||
|
|
||
| folly::Future<StatusOr<bool>> |
There was a problem hiding this comment.
StatusOr<bool> is identical to Status
| cpp2::ListUsersReq req; | ||
| return getResponse(std::move(req), [] (auto client, auto request) { | ||
| return client->future_listUsers(request); | ||
| }, [] (cpp2::ListUsersResp&& resp) -> decltype(auto) { |
There was a problem hiding this comment.
Please do a research on the difference between auto versus decltype(auto), don't use the latter one unless it's necessary.
boshengchen
added
in progress
do not review
|
Close this one . Will track this with #1873 . |
This one depends on PR #400 and PR #480 .
Please hold on this one .