Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rollup apply join #5244

Closed

Conversation

nevermore3
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #5209

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 changed the title add list wrapper fix rollup apply join Jan 12, 2023
@nevermore3 nevermore3 force-pushed the fix_rollupapply_edge_direction branch from 6580473 to 873f614 Compare January 12, 2023 08:38
}
};

struct WrapperEqual {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace std {
 template <>
 struct hash<ListWrapper> {
  size_t operator()(const ListWrapper& l) {}
 };
 template <>
  struct equal_to<ListWrapper> {
    int operator()(const ListWrapper&) {}
  };
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

RETURN ()-[e:like*2]->(n)
"""
Then the result should be, in any order:
| ()-[e:like*2]->(n) = ()-[e:like*2]->(n) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the column name is different with the query?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"""
MATCH (v:player{name: 'Tim Duncan'})-[e:like]->(n)
RETURN ()-[e:like]->(n)
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests: bi-direction

      MATCH (v:player{name: 'Tim Duncan'})-[e:like]-(n)
        RETURN ()-[e:like]-(n)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nevermore3 nevermore3 force-pushed the fix_rollupapply_edge_direction branch from 156e103 to 0095177 Compare January 16, 2023 06:25
@nevermore3 nevermore3 force-pushed the fix_rollupapply_edge_direction branch from 0095177 to fac07c2 Compare January 16, 2023 07:07
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Jan 16, 2023
@nevermore3 nevermore3 force-pushed the fix_rollupapply_edge_direction branch from fac07c2 to 30a6a74 Compare January 16, 2023 09:01
@nevermore3 nevermore3 closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match query's result is incorrect
2 participants