Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary check when print error log #5284

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

codesigner
Copy link
Contributor

@codesigner codesigner commented Jan 30, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

minor: check is wrong , and not necessary, just print error log if ratio is set a invalid value

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Base: 77.64% // Head: 78.71% // Increases project coverage by +1.07% 🎉

Coverage data is based on head (48dd68b) compared to base (cfb503e).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5284      +/-   ##
==========================================
+ Coverage   77.64%   78.71%   +1.07%     
==========================================
  Files        1110     1110              
  Lines       83350    83341       -9     
==========================================
+ Hits        64718    65606     +888     
+ Misses      18632    17735     -897     
Impacted Files Coverage Δ
src/common/memory/MemoryUtils.cpp 71.11% <0.00%> (+0.78%) ⬆️
src/common/memory/MemoryTracker.cpp 60.00% <0.00%> (-16.00%) ⬇️
src/common/memory/Memory.h 72.34% <0.00%> (-8.52%) ⬇️
src/common/memory/NewDelete.cpp 56.25% <0.00%> (-6.25%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/graph/optimizer/Optimizer.cpp 90.40% <0.00%> (-2.40%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.64%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
src/kvstore/wal/FileBasedWal.cpp 72.74% <0.00%> (-0.24%) ⬇️
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codesigner codesigner merged commit addc370 into vesoft-inc:master Jan 30, 2023
Sophie-Xie added a commit that referenced this pull request Feb 2, 2023
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants