Traverse executor in parallel #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
force-pushed
the
comm-multiple-traverse-opt
branch
5 times, most recently
from
d54970a
to
5f3989b
Compare
yixinglu
requested review from
nevermore3,
codesigner,
czpmango,
jievince and
xtcyclist
and removed request for
nevermore3
yixinglu
force-pushed
the
comm-multiple-traverse-opt
branch
from
5f3989b
to
fe650f4
Compare
jievince
reviewed
Feb 6, 2023
|
|
||
| folly::Future<Status> TraverseExecutor::expandOneStep(RpcResponse&& resps) { | ||
| auto numRows = numRowsOfRpcResp(resps); | ||
| if (numRows < FLAGS_traverse_parallel_threshold_rows) { |
There was a problem hiding this comment.
When return too many vertices from storage, the collect task will speed a lot time. so not use the parallel execution in that case.
yixinglu
force-pushed
the
comm-multiple-traverse-opt
branch
from
fe650f4
to
922d8ff
Compare
yixinglu
force-pushed
the
comm-multiple-traverse-opt
branch
from
922d8ff
to
3f152eb
Compare
jievince
approved these changes
Feb 6, 2023
nevermore3
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
run traverse executor in parallel when the number rows of response greater than the threshold value.
How do you solve it?
Expand each response of RPC in parallel
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: