-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor go planner #5369
Merged
Sophie-Xie
merged 30 commits into
vesoft-inc:master
from
nevermore3:refactor_go_planner
Mar 13, 2023
Merged
Refactor go planner #5369
Sophie-Xie
merged 30 commits into
vesoft-inc:master
from
nevermore3:refactor_go_planner
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
force-pushed
the
refactor_go_planner
branch
25 times, most recently
from
March 2, 2023 08:45
f2d7c25
to
51b4346
Compare
nevermore3
force-pushed
the
refactor_go_planner
branch
4 times, most recently
from
March 7, 2023 06:14
403a8cf
to
df5a329
Compare
nevermore3
force-pushed
the
refactor_go_planner
branch
from
March 13, 2023 03:26
85c8c0a
to
facb3a9
Compare
yixinglu
approved these changes
Mar 13, 2023
jievince
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc affected
PR: improvements or additions to documentation
incompatible
PR: incompatible with the recently released version
ready for review
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close https://github.com/vesoft-inc/nebula-ent/issues/2532
Description:
yield 'Tim Duncan' as a | go 3 steps from $-.a over like where like.likeness > 30 yield edge as e
previous plan
current plan
Due to the existence of the loop operator in the previous plan, the data flow and dependencies were inconsistent, so many optimization rules could not be applied, such as filter pushdown, merging projects, and so on.
in the new plan. the go statement is divided into two operators, expand and expandall, expand is responsible for expansion, and expandAll is responsible for the expansion process to obtain the attributes required by the user
BEFORE:
NOW:
the yellow line is the optimized version
the blue line is the master version
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: