Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimized udf build #5391

Merged
merged 4 commits into from
Mar 9, 2023
Merged

feat: optimized udf build #5391

merged 4 commits into from
Mar 9, 2023

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Mar 8, 2023

The indent character was wrong, now it's fixed and tested.

What type of PR is this?

  • bug
  • feature
  • enhancement

desc

  • Fixed the indentation character from white space to tab character
  • now, we could do make UDF=foo to build when we have foo.cpp and foo.h and it'll output foo.so

For docs update:

Example that could be used in docs

$ cd udf
$ ls standard_deviation*
standard_deviation.cpp  standard_deviation.h
$ make help
Usage: make UDF=<udf_name>
Example: make UDF=standard_deviation
$ make UDF=standard_deviation
g++ -c -I ../src/ -I ../build/third-party/install/include/ -fPIC standard_deviation.cpp -o standard_deviation.o
g++ -shared -o standard_deviation.so standard_deviation.o
$ ls *.so
standard_deviation.so

cc @cooper-lzy @abby-cyber @whitewum

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

n/a

wey-gu added 3 commits March 8, 2023 23:11
The indent character was wrong, now it's fixed and tested.
example: make UDF=standard_deviation
@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Mar 8, 2023
@wey-gu wey-gu changed the title fix udf build feat: optimized udf build Mar 8, 2023
@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test ready for review labels Mar 9, 2023
@wey-gu wey-gu requested a review from Sophie-Xie March 9, 2023 03:03
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Mar 9, 2023
@Sophie-Xie Sophie-Xie merged commit 430844b into master Mar 9, 2023
@Sophie-Xie Sophie-Xie deleted the wey-gu-patch-fix-udf-build branch March 9, 2023 03:43
@abby-cyber
Copy link
Contributor

ref: #4804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants