Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GetSnaphot will return nullptr #5420

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5240

Description:

GetSnaphot would check if the part is leader is not, when it is not, it will return nullptr. It will break the intent of snapshot, because when nullptr is passed to RocksDB, it will read based on latest data instead of the the snapshot we specified. So in this PR, the validation of leadership is removed.

Once use snapshot, user must know exactly what they are doing, because it will definitely read outdate data.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

SuperYoko
SuperYoko previously approved these changes Mar 21, 2023
@Sophie-Xie Sophie-Xie merged commit e3ae20d into vesoft-inc:master Mar 21, 2023
@critical27 critical27 deleted the fix branch March 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In some scenarios, the ‘sendSnapshot’ does not really transfer a Snapshot
4 participants