Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #5376
Description:
Add a flag to control which unit that ttl uses, user should not modify it after one ttl column is specified. This behavior has been discussed with @MuYiYong. I think the flag should not be exposed as well. For those scenario who want to use ttl in ms, just set the flag to true once and for all before any ttl column is specified.
For example, if
ttl_use_ms
is false by default, set a ttl column as 500, so data of 500 seconds ago are expired. If user changettl_use_ms
from false too true, data of 500ms ago are expired. So again, don't modify it unless no more ttl columns are used.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: