Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ttl in ms #5430

Merged
merged 1 commit into from
Mar 23, 2023
Merged

support ttl in ms #5430

merged 1 commit into from
Mar 23, 2023

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Mar 23, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5376

Description:

Add a flag to control which unit that ttl uses, user should not modify it after one ttl column is specified. This behavior has been discussed with @MuYiYong. I think the flag should not be exposed as well. For those scenario who want to use ttl in ms, just set the flag to true once and for all before any ttl column is specified.

For example, if ttl_use_ms is false by default, set a ttl column as 500, so data of 500 seconds ago are expired. If user change ttl_use_ms from false too true, data of 500ms ago are expired. So again, don't modify it unless no more ttl columns are used.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review labels Mar 23, 2023
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Mar 23, 2023
@critical27 critical27 merged commit 913cc8b into vesoft-inc:master Mar 23, 2023
@critical27 critical27 deleted the ttl branch March 23, 2023 07:38
@abby-cyber abby-cyber self-assigned this Mar 27, 2023
@abby-cyber
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL in millisecond
5 participants