Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redefined alias in match path #5446

Merged

Conversation

xtcyclist
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #5185

Description:

buildNodeInfo didn't check redefined aliases.

How do you solve it?

Check it.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test ready for review labels Mar 28, 2023
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Mar 28, 2023
yixinglu
yixinglu previously approved these changes Mar 28, 2023
@xtcyclist xtcyclist force-pushed the fix_redefined_alias_in_match_path branch from f8da838 to 0804c33 Compare March 28, 2023 07:19
@xtcyclist xtcyclist requested a review from yixinglu March 28, 2023 08:46
@xtcyclist xtcyclist merged commit 9316380 into vesoft-inc:master Mar 28, 2023
@xtcyclist xtcyclist deleted the fix_redefined_alias_in_match_path branch March 28, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing an error report on type conflicts of a redefined variable
5 participants