Support subscript in update.

src/common/function/FunctionManager.cpp

@@ -1708,7 +1708,6 @@ FunctionManager::FunctionManager() {
           if (args[0].get().isStr()) {
             auto result = time::TimeUtils::parseTime(args[0].get().getStr());
             if (!result.ok()) {
-              DLOG(ERROR) << "DEBUG POINT: " << result.status();
               return Value::kNullBadData;
             }
             if (result.value().withTimeZone) {

src/graph/validator/MutateValidator.cpp

@@ -756,7 +756,6 @@ Expression *UpdateValidator::rewriteSymExpr(Expression *expr,
       Expression::Kind::kVarProperty,
       Expression::Kind::kInputProperty,
       // Expression::Kind::kLabelAttribute, valid only for update edge
-      Expression::Kind::kSubscript,
       Expression::Kind::kUUID,
       Expression::Kind::kTagProperty,
       Expression::Kind::kLabelTagProperty,

src/storage/query/QueryBaseProcessor-inl.h

@@ -3,6 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
+#include "common/expression/SubscriptExpression.h"
+
 namespace nebula {
 namespace storage {
 
@@ -603,8 +605,19 @@ nebula::cpp2::ErrorCode QueryBaseProcessor<REQ, RESP>::checkExp(
       }
       return nebula::cpp2::ErrorCode::SUCCEEDED;
     }
+    case Expression::Kind::kSubscript: {
+      auto sbExpr = static_cast<const SubscriptExpression*>(exp);
+      auto ret = checkExp(sbExpr->left(), returned, filtered, updated, allowNoexistentProp);
+      if (ret != nebula::cpp2::ErrorCode::SUCCEEDED) {
+        return ret;
+      }
+      ret = checkExp(sbExpr->right(), returned, filtered, updated, allowNoexistentProp);
+      if (ret != nebula::cpp2::ErrorCode::SUCCEEDED) {
+        return ret;
+      }
+      return nebula::cpp2::ErrorCode::SUCCEEDED;
+    }
     case Expression::Kind::kInputProperty:
-    case Expression::Kind::kSubscript:
     case Expression::Kind::kLabelTagProperty:
     case Expression::Kind::kLabelAttribute:
     case Expression::Kind::kVertex:

tests/tck/features/bugfix/SubscriptInUpdate.feature

@@ -0,0 +1,50 @@
+# Copyright (c) 2023 vesoft inc. All rights reserved.
+#
+# This source code is licensed under Apache 2.0 License.
+Feature: Test subscript in update
+
+  # #5445
+  Scenario: Subscript in update
+    Given an empty graph
+    And create a space with following options:
+      | partition_num  | 1                |
+      | replica_factor | 1                |
+      | vid_type       | FIXED_STRING(30) |
+      | charset        | utf8             |
+      | collate        | utf8_bin         |
+    When executing query:
+      """
+      create tag test_tag(i1 int, json string);
+      create edge test_edge(i1 int, json string);
+      """
+    Then the execution should be successful
+    When try to execute query:
+      """
+      INSERT VERTEX test_tag(i1, json) VALUES 'xxx':(1, '{"a":1,"b":2}');
+      """
+    Then the execution should be successful
+    When try to execute query:
+      """
+      UPDATE VERTEX ON test_tag 'xxx'
+      SET i1=json_extract(json)['b']
+      WHEN json_extract(json)['a'] == 1
+      YIELD i1;
+      """
+    Then the result should be, in any order:
+      | i1 |
+      | 2  |
+    When try to execute query:
+      """
+      INSERT EDGE test_edge(i1, json) VALUES 'xxx'->'xxx':(1, '{"a":1,"b":2}');
+      """
+    Then the execution should be successful
+    When try to execute query:
+      """
+      UPDATE EDGE ON test_edge 'xxx'->'xxx'
+      SET i1=json_extract(json)['b']
+      WHEN json_extract(json)['a'] == 1
+      YIELD i1;
+      """
+    Then the result should be, in any order:
+      | i1 |
+      | 2  |