Split optimizer rules #5470
Merged
Split optimizer rules #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
previously approved these changes
Apr 3, 2023
nevermore3
reviewed
Apr 4, 2023
jievince
previously approved these changes
Apr 4, 2023
czpmango
force-pushed
the
enhancement/split-opt-rules
branch
6 times, most recently
from
c8db054
to
08de6f2
Compare
Fix compile small rename Fix tck Fix tck fmt Fix tck Fix tck
czpmango
force-pushed
the
enhancement/split-opt-rules
branch
from
08de6f2
to
847cf27
Compare
czpmango
added
ready for review
and removed
do not review
yixinglu
reviewed
Apr 6, 2023
| @@ -6,6 +6,7 @@ Feature: Collapse Project Rule | |||
| Background: | |||
| Given a graph with space named "nba" | |||
|
|
|||
| @czp | |||
yixinglu
approved these changes
Apr 7, 2023
Sophie-Xie
pushed a commit
that referenced
this pull request
Apr 13, 2023
Fix compile small rename Fix tck Fix tck fmt Fix tck Fix tck
dutor
added a commit
that referenced
this pull request
Apr 20, 2023
* refactor traverse output (#5464) * refactor traverse output * fix pruneproperties error & none_direct_dst * fix test error * fix shortest path * Change the compaction filter logic to let periodic compaction go through custom compaction filter, to gc expired data (#5447) * Push filter down cross join (#5473) * fix comment * push down filter through cross join --------- Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix shortest path crash (#5472) * fix crash of geo (#5475) * fix crash of geo * change log(fatal) to log(error) * fix miss arg $GITHUB_OUTPUT (#5478) * Split optimizer rules (#5470) Fix compile small rename Fix tck Fix tck fmt Fix tck Fix tck * Enhancement/optimize edge all predicate (#5481) * fix eval contains filter on storaged (#5485) * fix eval contains filter on storaged * add tck case * add tck case * fix tck * fix lint * fix lint * Fix expression util function (#5487) fmt Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix ContainsFilter random fail (#5489) * Fixed graphd startup issue (#5493) * fix prunproperties (#5494) * stop the pushing down of not expressions that are not rewritten to proper forms. (#5502) * Fix edge all predicate with rank function (#5503) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * rewrite param in subgraph & path (#5500) * check param in subgraph * rewrite param in path --------- Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix concurrent bug about session count (#5496) * Fix regex expression (#5507) * Update requirements.txt (#5512) Solidified tomli version to solve centos7 compatibility issues * Update cluster id (#5514) --------- Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Ryan <ydlu1987@gmail.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: codesigner <codesigner.huang@vesoft.com> Co-authored-by: dutor <440396+dutor@users.noreply.github.com> Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Split the optimizer rule
PushFilterDownTraverseRuletoPushFilterThroughAppendVerticesRuleandPushFilterDownTraverseRule.This pr is for refactoring purposes but also introduces some optimizations, such as non-endpoint predicates that can be pushed down before AppendVertices.
The purpose of refactoring is that the previous implementation was too ad-hoc for further optimization, and there were some conflicts between rules, so we should try to avoid similar code implementation from a more common perspective, especially for the development of optimizer.
Checklist:
Tests:
Affects: