Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix leader cache #5539

Merged
merged 1 commit into from
May 9, 2023
Merged

fix leader cache #5539

merged 1 commit into from
May 9, 2023

Conversation

HarrisChu
Copy link
Contributor

@HarrisChu HarrisChu commented May 6, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

when restart graphd, it would update the storage part leader from meta.
but spaceIndexByName_ has no value yet.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label May 6, 2023
critical27
critical27 approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goood job

@Sophie-Xie Sophie-Xie merged commit beccb78 into vesoft-inc:master May 9, 2023
Sophie-Xie pushed a commit that referenced this pull request May 12, 2023
@HarrisChu @Sophie-Xie
fix leader cache (#5539)
12bacc5
Sophie-Xie added a commit that referenced this pull request May 12, 2023
@Sophie-Xie @HarrisChu @nevermore3
Cherry pick 3.5 (0428-0512) (#5549)
5a53e3f 
* fix leader cache (#5539)

* change bfs to bibfs in allpath (#5542)

* change bfs to bibfs in allpath

* fix error

* add lock for stats

* address comment

* simple case m to n (#5543)

* simple case m to n

* fix error

---------

Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
@wey-gu wey-gu mentioned this pull request May 13, 2023
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @HarrisChu
fix leader cache (vesoft-inc#5539) (vesoft-inc#2758)
78e9fdd 
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@SuperYoko SuperYoko SuperYoko approved these changes

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
already-picked-3.5 cherry-pick-v3.5 ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarrisChu @critical27 @SuperYoko @Sophie-Xie