Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash double free of expr. #5557

Merged
merged 2 commits into from
May 22, 2023
Merged

Fix crash double free of expr. #5557

merged 2 commits into from
May 22, 2023

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 22, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5558

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label May 22, 2023
@Shylock-Hg Shylock-Hg requested a review from codesigner May 22, 2023 07:53
@HarrisChu
Copy link
Contributor

https://github.com/vesoft-inc/nebula/pull/5290/files

@Sophie-Xie Sophie-Xie merged commit ae43d7d into vesoft-inc:master May 22, 2023
Sophie-Xie pushed a commit that referenced this pull request May 22, 2023
@Shylock-Hg @Sophie-Xie
Fix crash double free of expr. (#5557)
f80e3da 
* Fix crash double free of expr.

* Change issue id.
Sophie-Xie added a commit that referenced this pull request May 22, 2023
@Sophie-Xie @Shylock-Hg
Cherry pick 3.5 (0516-0522) (#5559)
18fd7b1 
Fix crash double free of expr. (#5557)

* Fix crash double free of expr.

* Change issue id.

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
@wey-gu wey-gu mentioned this pull request May 27, 2023
Closed
@Shylock-Hg Shylock-Hg deleted the fix/syntax-crash branch May 30, 2023 02:17
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @Shylock-Hg
Fix crash double free of expr. (vesoft-inc#5557) (vesoft-inc#2785)
558eb01 
* Fix crash double free of expr.

* Change issue id.

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtcyclist xtcyclist xtcyclist approved these changes

@codesigner codesigner codesigner approved these changes

@dutor dutor dutor approved these changes

Assignees
No one assigned
Labels
already-picked-3.5 cherry-pick-v3.5 ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphd crashed executing match query
6 participants
@Shylock-Hg @HarrisChu @dutor @codesigner @xtcyclist @Sophie-Xie