Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web service crash if set flag with invalid request parameter #5566

Merged
merged 1 commit into from
May 31, 2023

Conversation

luyade
Copy link
Contributor

@luyade luyade commented May 30, 2023

What type of PR is this?

  • bug

What problem(s) does this PR solve?

Issue(s) number: fix #5506

Description:

Fix web service crash if the request parameter is invalid. In this issue, if the config value is not string, the item.second.asString() in the source code will lead an exception.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu requested review from dutor, Aiee and jievince May 31, 2023 02:30
@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label May 31, 2023
@Sophie-Xie Sophie-Xie merged commit 6415db5 into vesoft-inc:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl change rocksdb_column_family_options config with wrong format will lead to storage crash
4 participants