Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft search #5567

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Ft search #5567

merged 7 commits into from
Jun 6, 2023

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs requested review from dutor, codesigner and a team as code owners May 31, 2023 06:07
@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label May 31, 2023
critical27
critical27 previously approved these changes Jun 2, 2023
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some tck using fulltext index failed, test_fulltext_ddl.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage: 32.20% and project coverage change: +0.54 🎉

Comparison is base (6415db5) 77.26% compared to head (d4ef37d) 77.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5567      +/-   ##
==========================================
+ Coverage   77.26%   77.81%   +0.54%     
==========================================
  Files        1125     1125              
  Lines       85203    85096     -107     
==========================================
+ Hits        65833    66217     +384     
+ Misses      19370    18879     -491     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 77.98% <0.00%> (+1.57%) ⬆️
src/common/expression/Expression.cpp 53.90% <0.00%> (+0.78%) ⬆️
src/common/expression/Expression.h 100.00% <ø> (ø)
...c/common/plugin/fulltext/elasticsearch/ESAdapter.h 28.57% <ø> (-31.43%) ⬇️
src/common/utils/MetaKeyUtils.cpp 84.80% <ø> (+1.54%) ⬆️
src/graph/executor/maintain/FTIndexExecutor.h 100.00% <ø> (+100.00%) ⬆️
...graph/executor/query/FulltextIndexScanExecutor.cpp 0.00% <0.00%> (ø)
...c/graph/executor/query/FulltextIndexScanExecutor.h 0.00% <ø> (ø)
src/graph/planner/ngql/LookupPlanner.cpp 50.00% <0.00%> (ø)
src/graph/planner/plan/Query.cpp 65.05% <0.00%> (ø)
... and 13 more

... and 61 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shinji-IkariG Shinji-IkariG merged commit e819402 into vesoft-inc:master Jun 6, 2023
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
* Ft search (vesoft-inc#5567)

* Add optimizer rule for pushing limit into the fulltext index scan (vesoft-inc#5575)

* Merge limit and full text index scan rule (vesoft-inc#5577)

* Support to return score from es query (vesoft-inc#5580)

* modify ft search (vesoft-inc#5584)

* modify ft search

* fix bug

* address some comment

* fix bug

* fix conflict

---------

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants