Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all path memory tracker #5621

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Jul 6, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/2906

Description:

before:
image

now:

(root@nebula) [nba]> go from 'Tim Duncan' over * yield id($$) as dst| find all path from $-.dst to $-.dst  over * bidirect upto 100 steps yield path as p |yield count(*)
[ERROR (-1005)]: GraphMemoryExceeded: (-2600)

Thu, 06 Jul 2023 10:45:24 CST
image

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 53.12% and project coverage change: +1.30 🎉

Comparison is base (e469b32) 76.96% compared to head (dbb903d) 78.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5621      +/-   ##
==========================================
+ Coverage   76.96%   78.27%   +1.30%     
==========================================
  Files        1130     1130              
  Lines       85345    85372      +27     
==========================================
+ Hits        65686    66824    +1138     
+ Misses      19659    18548    -1111     
Impacted Files Coverage Δ
src/kvstore/raftex/Host.h 87.80% <ø> (+4.87%) ⬆️
src/kvstore/raftex/RaftPart.cpp 70.67% <ø> (+0.47%) ⬆️
src/kvstore/raftex/Host.cpp 70.83% <46.42%> (-1.52%) ⬇️
src/graph/executor/algo/AllPathsExecutor.cpp 85.21% <100.00%> (+0.03%) ⬆️
...eta/processors/session/SessionManagerProcessor.cpp 79.06% <100.00%> (-0.13%) ⬇️

... and 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nevermore3
Copy link
Contributor Author

Do not merge into the master, waiting for testother scenes

codesigner
codesigner previously approved these changes Jul 6, 2023
@Sophie-Xie Sophie-Xie added do not review PR: not ready for the code review yet and removed ready for review labels Jul 7, 2023
@nevermore3 nevermore3 removed the ready-for-testing PR: ready for the CI test label Jul 7, 2023
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review and removed do not review PR: not ready for the code review yet labels Jul 9, 2023
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Jul 9, 2023
@Sophie-Xie
Copy link
Contributor

Do not merge into the master, waiting for testother scenes

it's fine

@Sophie-Xie Sophie-Xie merged commit a157e95 into vesoft-inc:master Jul 10, 2023
@nevermore3 nevermore3 deleted the fix_allpath_memory_tracker branch July 12, 2023 07:42
Sophie-Xie added a commit that referenced this pull request Jul 20, 2023
* fix all path memory tracker

* fix error

* Update pull_request.yml

enable sccache debug log

* Update pull_request.yml

add ninja -v

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

---------

Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sophie-Xie added a commit that referenced this pull request Jul 20, 2023
* fix traverse build path memory tracker (#5619)

* Optimize the write performance when host is down (#5571)

* Optimize the write performance when host is down

* fix the comments

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix too many logs print when listing sessions (#5618)

* Set min_level_for_custom_filter as 0 by default to delete expired d… (#5622)

Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction

* Revert "Revert "Change ccache to sccache"" (#5623)

* Revert "Revert "Change ccache to sccache" (#5613)"

This reverts commit 08a5d90.

* Update pull_request.yml

* Revert  "Change ccache to sccache" (#5627)

Revert "Revert "Revert "Change ccache to sccache"" (#5623)"

This reverts commit c1b433d.

* fix all path memory tracker (#5621)

* fix all path memory tracker

* fix error

* Update pull_request.yml

enable sccache debug log

* Update pull_request.yml

add ninja -v

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

---------

Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix edge all predicate embedding when generating path (#5631)

* Fix edge all predicate embedding when generate path

* fmt

* Enhancement/eliminate invalid filter (#5634)

* Fix crash double free of expr.

* Change issue id.

* Elimintate invalid property filter.

* support find circular (#5636)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix allpath memory tracker (#5640)

fix allpath memory traker

* fix_delete_validate (#5645)

add test case

---------

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Ryan <ydlu1987@gmail.com>
Co-authored-by: Songqing Zhang <zhangsongqing164@163.com>
Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants