Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push limit down shortestpath #5657

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Jul 26, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the push_limit_down_shortestpath branch from 81d08dc to d1716f6 Compare July 26, 2023 12:37
@nevermore3 nevermore3 changed the title Push limit down shortestpath [DNM]Push limit down shortestpath Jul 26, 2023
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Jul 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 54.31% and project coverage change: +1.12% 🎉

Comparison is base (e320ec5) 77.10% compared to head (ed72e3b) 78.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5657      +/-   ##
==========================================
+ Coverage   77.10%   78.23%   +1.12%     
==========================================
  Files        1133     1133              
  Lines       85500    85609     +109     
==========================================
+ Hits        65926    66973    +1047     
+ Misses      19574    18636     -938     
Files Changed Coverage Δ
src/graph/executor/algo/BFSShortestPathExecutor.h 100.00% <ø> (ø)
...rc/graph/executor/algo/MultiShortestPathExecutor.h 100.00% <ø> (ø)
src/graph/planner/plan/Algo.cpp 34.07% <0.00%> (-7.37%) ⬇️
src/parser/Clauses.h 94.00% <0.00%> (-2.42%) ⬇️
src/parser/TraverseSentences.cpp 92.15% <33.33%> (-0.88%) ⬇️
...rc/graph/executor/algo/BFSShortestPathExecutor.cpp 91.75% <62.96%> (-5.20%) ⬇️
src/graph/validator/FindPathValidator.cpp 87.03% <66.66%> (-1.20%) ⬇️
.../graph/executor/algo/MultiShortestPathExecutor.cpp 92.82% <70.27%> (-4.15%) ⬇️
src/graph/planner/ngql/PathPlanner.cpp 100.00% <100.00%> (ø)
src/graph/planner/plan/Algo.h 100.00% <100.00%> (ø)
... and 1 more

... and 87 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevermore3 nevermore3 removed the ready-for-testing PR: ready for the CI test label Aug 7, 2023
@nevermore3 nevermore3 changed the title [DNM]Push limit down shortestpath Push limit down shortestpath Aug 7, 2023
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels Aug 7, 2023
yixinglu
yixinglu previously approved these changes Aug 7, 2023
yixinglu
yixinglu previously approved these changes Aug 8, 2023
jievince
jievince previously approved these changes Aug 8, 2023
@nevermore3 nevermore3 dismissed stale reviews from jievince and yixinglu via 5815f46 August 8, 2023 06:17
@yixinglu yixinglu merged commit d0086dd into vesoft-inc:master Aug 8, 2023
2 of 4 checks passed
@nevermore3 nevermore3 deleted the push_limit_down_shortestpath branch August 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants