-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mode for Round
#5680
Mode for Round
#5680
Conversation
Wow, welcome to the NebulaGraph community!! 🚀 Would you mind adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the clean PR!
Thank you!! This project is really cool!! |
I fixed the format of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
Dear @Koukyosyumei , Just to ping you in case you missed the notification of the review :D, not pushy, kindly check @czpmango 's review comment when it's comfortable for you. Thanks! BR//Wey |
Sorry for the late response. I'm currently working on it!! |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #5680 +/- ##
==========================================
+ Coverage 77.03% 78.30% +1.27%
==========================================
Files 1133 1133
Lines 85775 85823 +48
==========================================
+ Hits 66073 67202 +1129
+ Misses 19702 18621 -1081
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM.
Dear @Koukyosyumei , Many thanks for your great contribution🎉! @QingZ11 will reach out to you for the contributor certification/souvenir. BR//Wey |
Thank all of you for this great opportunity and helpful suggestions! I will keep contributing to this fantastic project!! |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close #3237
Description:
I added 7 modes implemented in neo4j.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: