Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode for Round #5680

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Mode for Round #5680

merged 15 commits into from
Aug 23, 2023

Conversation

Koukyosyumei
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #3237

Description:

I added 7 modes implemented in neo4j.

UP Round away from zero.
DOWN Round towards zero.
CEILING Round towards positive infinity.
FLOOR Round towards negative infinity.
HALF_UP Round towards closest value of given precision, with ties always being rounded away from zero.
HALF_DOWN Round towards closest value of given precision, with ties always being rounded towards zero.
HALF_EVEN Round towards closest value of given precision, with ties always being rounded to the even neighbor.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@wey-gu
Copy link
Contributor

wey-gu commented Aug 16, 2023

Wow, welcome to the NebulaGraph community!! 🚀

Would you mind adding a round.feature e2e test under tests/tck/features/function?

@wey-gu wey-gu requested review from yixinglu and czpmango August 16, 2023 10:18
wey-gu
wey-gu previously approved these changes Aug 16, 2023
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the clean PR!

@Koukyosyumei
Copy link
Contributor Author

Thank you!! This project is really cool!!

@wey-gu wey-gu added the ready-for-testing PR: ready for the CI test label Aug 16, 2023
@Koukyosyumei
Copy link
Contributor Author

I fixed the format of round.feature

yixinglu
yixinglu previously approved these changes Aug 17, 2023
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

@wey-gu
Copy link
Contributor

wey-gu commented Aug 18, 2023

Dear @Koukyosyumei ,

Just to ping you in case you missed the notification of the review :D, not pushy, kindly check @czpmango 's review comment when it's comfortable for you. Thanks!

BR//Wey

@Koukyosyumei
Copy link
Contributor Author

Dear @Koukyosyumei ,

Just to ping you in case you missed the notification of the review :D, not pushy, kindly check @czpmango 's review comment when it's comfortable for you. Thanks!

BR//Wey

Sorry for the late response. I'm currently working on it!!

yixinglu
yixinglu previously approved these changes Aug 18, 2023
@wey-gu wey-gu requested review from czpmango and yixinglu August 18, 2023 10:54
@wey-gu
Copy link
Contributor

wey-gu commented Aug 19, 2023

@yixinglu @yixinglu I think this change is in good shape to move forward:)

@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Aug 21, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 95.45% and project coverage change: +1.27% 🎉

Comparison is base (7c32088) 77.03% compared to head (da6ea64) 78.30%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5680      +/-   ##
==========================================
+ Coverage   77.03%   78.30%   +1.27%     
==========================================
  Files        1133     1133              
  Lines       85775    85823      +48     
==========================================
+ Hits        66073    67202    +1129     
+ Misses      19702    18621    -1081     
Files Changed Coverage Δ
src/common/function/FunctionManager.cpp 78.87% <95.34%> (+0.36%) ⬆️
src/graph/executor/admin/ListenerExecutor.cpp 78.84% <100.00%> (ø)

... and 93 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@yixinglu yixinglu merged commit 793c914 into vesoft-inc:master Aug 23, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Aug 23, 2023

Dear @Koukyosyumei ,

Many thanks for your great contribution🎉! @QingZ11 will reach out to you for the contributor certification/souvenir.

BR//Wey

@Koukyosyumei
Copy link
Contributor Author

Thank all of you for this great opportunity and helpful suggestions! I will keep contributing to this fantastic project!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model for round build-in function
7 participants