Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-MemoryTracker master #5808

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

769344359
Copy link
Contributor

@769344359 769344359 commented Jan 19, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#5807

Description:

try to fix it

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@QingZ11 QingZ11 requested a review from codesigner January 22, 2024 02:58
codesigner
codesigner previously approved these changes Jan 22, 2024
Copy link
Contributor

@codesigner codesigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinks for the fix.

@codesigner codesigner added the ready-for-testing PR: ready for the CI test label Jan 22, 2024
@QingZ11
Copy link
Contributor

QingZ11 commented Jan 26, 2024

The PR needs to pass the related automated tests. We are continuously re-running the tests, and once they pass, the PR will be merged. This is because it has already been reviewed by the relevant personnel. And thank you for your contribution.

@Salieri-004
Copy link
Contributor

Thanks for your help, I skipped the currently problematic test case.

@codesigner codesigner merged commit fc34170 into vesoft-inc:master Feb 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants