Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#424 to make Expression::eval to be able to do error handle #669

Merged
merged 6 commits into from
Aug 12, 2019
Merged

Issue#424 to make Expression::eval to be able to do error handle #669

merged 6 commits into from
Aug 12, 2019

Conversation

monadbobo
Copy link
Contributor

@monadbobo monadbobo commented Jul 22, 2019 •
edited by dutor
Loading 

Issue#424 to make `Expression::eval` to be able to do error handle.
Summary:

1. When the expression is evaluated, some wrong judgments are added,
   ifthe expression was failed, an error will be replyed to the user.

2 fixed the crash when using mockStorageServer.

close #424

@monadbobo
Issue#424 to make Expression::eval to be able to do error handling.
5393497 
    Summary:

    1. When the expression is evaluated, some wrong judgments are added,
       ifthe expression was failed, an error will be replyed to the user.

    2 fixed the crash when using mockStorageServer.
@monadbobo monadbobo added the ready-for-testing PR: ready for the CI test label Jul 22, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding reviewed Jul 22, 2019
View reviewed changes
src/graph/GoExecutor.cpp Show resolved Hide resolved
src/common/filter/Expressions.cpp Outdated Show resolved Hide resolved
src/common/filter/Expressions.cpp Show resolved Hide resolved
@monadbobo
Copy link
Contributor Author

monadbobo commented Aug 1, 2019 •
edited
Loading

close #424 #626

@nebula-community-bot
Copy link
Member

Unit testing passed.

CPWstatic
CPWstatic reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I also have some questions, please take a look.

@nebula-community-bot
Copy link
Member

Unit testing passed.

CPWstatic
CPWstatic previously approved these changes Aug 8, 2019
View reviewed changes
@nebula-community-bot
Copy link
Member

Unit testing passed.

@monadbobo monadbobo requested a review from jude-zhu August 9, 2019 02:11
CPWstatic
CPWstatic reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/graph/FetchEdgesExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GoExecutor.cpp Outdated Show resolved Hide resolved
@monadbobo
1 reformat the code.
060617c 
2 Handled some errors.
@nebula-community-bot
Copy link
Member

Unit testing passed.

@jude-zhu jude-zhu requested a review from CPWstatic August 9, 2019 08:37
dutor
dutor approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor mentioned this pull request Aug 12, 2019
Merged
@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit a0354ac into vesoft-inc:master Aug 12, 2019
@monadbobo monadbobo mentioned this pull request Aug 12, 2019
Closed
@zhangguoqing zhangguoqing mentioned this pull request Aug 27, 2019
Merged
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@monadbobo @dutor
Error handling in Expression::eval (vesoft-inc#669)
6ac3901 
*     Issue#424 to make `Expression::eval` to be able to do error handling.

    Summary:

    1. When the expression is evaluated, some wrong judgments are added,
       ifthe expression was failed, an error will be replyed to the user.

    2 fixed the crash when using mockStorageServer.

* 1 reformat the code.
2 Handled some errors.
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@monadbobo @dutor
Error handling in Expression::eval (vesoft-inc#669)
78d0d75 
*     Issue#424 to make `Expression::eval` to be able to do error handling.

    Summary:

    1. When the expression is evaluated, some wrong judgments are added,
       ifthe expression was failed, an error will be replyed to the user.

    2 fixed the crash when using mockStorageServer.

* 1 reformat the code.
2 Handled some errors.
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@CPWstatic
Add -ent for ent-release. (vesoft-inc#669)
7a8529b 
confirm with sophie.xie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@CPWstatic CPWstatic CPWstatic approved these changes

@dangleptr dangleptr Awaiting requested review from dangleptr

@jude-zhu jude-zhu Awaiting requested review from jude-zhu

@laura-ding laura-ding Awaiting requested review from laura-ding

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To make Expression::eval to be able to do error handling
5 participants
@monadbobo @nebula-community-bot @dutor @CPWstatic @laura-ding