-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#424 to make Expression::eval
to be able to do error handle
#669
Issue#424 to make Expression::eval
to be able to do error handle
#669
Conversation
Summary: 1. When the expression is evaluated, some wrong judgments are added, ifthe expression was failed, an error will be replyed to the user. 2 fixed the crash when using mockStorageServer.
Unit testing passed. |
…_handling_issue424
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But I also have some questions, please take a look.
…r_handling_issue424
Unit testing passed. |
…_handling_issue424
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
2 Handled some errors.
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Unit testing passed. |
* Issue#424 to make `Expression::eval` to be able to do error handling. Summary: 1. When the expression is evaluated, some wrong judgments are added, ifthe expression was failed, an error will be replyed to the user. 2 fixed the crash when using mockStorageServer. * 1 reformat the code. 2 Handled some errors.
* Issue#424 to make `Expression::eval` to be able to do error handling. Summary: 1. When the expression is evaluated, some wrong judgments are added, ifthe expression was failed, an error will be replyed to the user. 2 fixed the crash when using mockStorageServer. * 1 reformat the code. 2 Handled some errors.
confirm with sophie.xie
close #424