Implement snapshot logic #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monadbobo
reviewed
Aug 17, 2019
dangleptr
added
ready-for-testing
|
Jenkins go |
|
Unit testing failed. |
2 similar comments
|
Unit testing failed. |
|
Unit testing failed. |
|
Unit testing failed. |
1 similar comment
|
Unit testing failed. |
|
Unit testing failed. |
dangleptr
added
in progress
ready-for-testing
|
Jenkins go |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
critical27
reviewed
Aug 22, 2019
wadeliuyi
reviewed
Aug 22, 2019
wadeliuyi
reviewed
Aug 22, 2019
wadeliuyi
reviewed
Aug 22, 2019
wadeliuyi
reviewed
Aug 22, 2019
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing passed. |
3 similar comments
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
critical27
approved these changes
Aug 31, 2019
Merged
monadbobo
reviewed
Sep 2, 2019
darionyaphet
reviewed
Sep 3, 2019
darionyaphet
reviewed
Sep 3, 2019
darionyaphet
reviewed
Sep 3, 2019
darionyaphet
reviewed
Sep 3, 2019
darionyaphet
reviewed
Sep 3, 2019
|
LGTM & thanks for you explain. |
darionyaphet
approved these changes
Sep 3, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Implement snapshot logic * Address critical27's and wadeliuyi's comments * Address darion's and wadeliuyi's comments, rebase on master and fix failed UTs * Address wadeliuyi's comments * Fix failed UT leader_transfer_test * Open disabled UTs in vesoft-inc#859 * Add some checks when receiving snapshot and adjust some log levels
liwenhui-soul
pushed a commit
to liwenhui-soul/nebula
that referenced
this pull request
May 10, 2022
* fix updatePart * fix format check Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #182