-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic metrics in storage service #872
Conversation
Unit testing passed. |
Unit testing failed. |
Jenkins go, please don't abort - -! |
Unit testing passed. |
Unit testing passed. |
1 similar comment
Unit testing passed. |
Unit testing passed. |
1 similar comment
Unit testing passed. |
Unit testing passed. |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to get the result of statsmanger? I have no see, will use Http?
Yeah, u r right |
Unit testing passed. |
How to get the metrics? Could you describe it in the summary? |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the usage about StorageIntegrityTool
Unit testing failed. |
add some basic stats in storage
Unit testing passed. |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job 🎉
rebase on upstream/master address @darionyaphet's comments
Unit testing passed. |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Add basic metrics for data operation in storage service 2. Add a storage integrity test tool in storage-perf. close vesoft-inc#287 Now we support following metrics: get_bound, bound_stats, vertex_props, edge_props, add_vertex, add_edge, del_vertex, update_vertex, update_edge. We can get qps or latency from these metrics (add suffix), for example: vertex_props_qps or vertex_props_latency. You can get a single metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60 If you want get multiple metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60,vertex_props_latency.avg.60,vertex_props_latency.p99.60&returnjson" We can get qps, avg latency and p99 latency in a minutue. You can get all metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats" The storage integrity tool is used for verifying data integrity in storage. It only works for single replica for now. You can use it like this: ./storage_integrity --meta_server_addrs=192.168.8.5:60001 --first_vertex_id=100 --width=1000 --height=1000 meta_server_addrs is the meta server addresss. first_vertex_id is the first vertex id which we inserts. width and height is the width and height of the big matrix.
relate to #185 |
1. Add basic metrics for data operation in storage service 2. Add a storage integrity test tool in storage-perf. close vesoft-inc#287 Now we support following metrics: get_bound, bound_stats, vertex_props, edge_props, add_vertex, add_edge, del_vertex, update_vertex, update_edge. We can get qps or latency from these metrics (add suffix), for example: vertex_props_qps or vertex_props_latency. You can get a single metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60 If you want get multiple metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60,vertex_props_latency.avg.60,vertex_props_latency.p99.60&returnjson" We can get qps, avg latency and p99 latency in a minutue. You can get all metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats" The storage integrity tool is used for verifying data integrity in storage. It only works for single replica for now. You can use it like this: ./storage_integrity --meta_server_addrs=192.168.8.5:60001 --first_vertex_id=100 --width=1000 --height=1000 meta_server_addrs is the meta server addresss. first_vertex_id is the first vertex id which we inserts. width and height is the width and height of the big matrix.
1. Add basic metrics for data operation in storage service 2. Add a storage integrity test tool in storage-perf. close vesoft-inc#287 Now we support following metrics: get_bound, bound_stats, vertex_props, edge_props, add_vertex, add_edge, del_vertex, update_vertex, update_edge. We can get qps or latency from these metrics (add suffix), for example: vertex_props_qps or vertex_props_latency. You can get a single metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60 If you want get multiple metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60,vertex_props_latency.avg.60,vertex_props_latency.p99.60&returnjson" We can get qps, avg latency and p99 latency in a minutue. You can get all metrics like this: curl -G "http://127.0.0.1:50005/get_stats?stats" The storage integrity tool is used for verifying data integrity in storage. It only works for single replica for now. You can use it like this: ./storage_integrity --meta_server_addrs=192.168.8.5:60001 --first_vertex_id=100 --width=1000 --height=1000 meta_server_addrs is the meta server addresss. first_vertex_id is the first vertex id which we inserts. width and height is the width and height of the big matrix.
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Romi <romi.chen@vesoft.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
close #287
Now we support following metrics:
get_bound, bound_stats, vertex_props, edge_props, add_vertex, add_edge, del_vertex, update_vertex, update_edge
.We can get qps or latency from these metrics (add suffix), for example:
vertex_props_qps
orvertex_props_latency
.You can get a single metrics like this:
curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60
If you want get multiple metrics like this:
curl -G "http://127.0.0.1:50005/get_stats?stats=vertex_props_qps.rate.60,vertex_props_latency.avg.60,vertex_props_latency.p99.60&returnjson"
We can get qps, avg latency and p99 latency in a minutue.
You can get all metrics like this:
curl -G "http://127.0.0.1:50005/get_stats?stats"
The storage integrity tool is used for verifying data integrity in storage. It only works for single replica for now. You can use it like this:
./storage_integrity --meta_server_addrs=192.168.8.5:60001 --first_vertex_id=100 --width=1000 --height=1000
meta_server_addrs
is the meta server addresss.first_vertex_id
is the first vertex id which we inserts.width
andheight
is the width and height of the big matrix.