Support general storage in StorageService #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
added
do not review
darionyaphet
requested review from
dutor,
CPWstatic,
critical27,
dangleptr,
whitewum and
jude-zhu
critical27
reviewed
Sep 26, 2019
dangleptr
reviewed
Sep 27, 2019
src/daemons/BenchmarkDaemon.cpp
Outdated
| @@ -0,0 +1,120 @@ | |||
| /* Copyright (c) 2019 vesoft inc. All rights reserved. | |||
There was a problem hiding this comment.
Let's move it into tools dir, and use another name "SimpleKVVerifyTool"
There was a problem hiding this comment.
Should I move it as test case or benchmark ?
There was a problem hiding this comment.
No, it is not a UT or a benchmark
darionyaphet
added
ready-for-testing
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
close #973 |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* support general storage in StorageService * fix nebula benchmark crash * Simple KV Verify Tool
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* support general storage in StorageService * fix nebula benchmark crash * Simple KV Verify Tool
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: force cache the docker layer. the layer is about 20GB, and need another 20min to export the layer. after then each job would need 5min with the cache layer. ## How do you solve it? ## Special notes for your reviewer, ex. impact of this fix, design document, etc: ## Checklist: Tests: - [ ] Unit test(positive and negative cases) - [ ] Function test - [ ] Performance test - [ ] N/A Affects: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.） - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory ## Release notes: Please confirm whether to be reflected in release notes and how to describe: > ex. Fixed the bug ..... Migrated from vesoft-inc#4331 Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will support put and get in storage engine.