-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fasthtml demo-app #1446
Conversation
Guess the space needs to be publicly available for the link check to pass, so did that now. |
Great! Minor comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks mostly great. Just one small UI feedback point :)
Article( | ||
Header( | ||
H2( | ||
A( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the UI a bit weird that this is displayed as a Link but it doesn't take you anywhere. Is the idea that a full application would implement this link?
Maybe you can just set it as H2 to not be so confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it should open the document when clicked.
It does not show the actual links in browser though, as it is running in hf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see now I am getting an internal server error when I try to access the links so nothing happens in the UI. This link gives a 500. https://vespa-engine-fasthtml-vespa.hf.space/document/MED-2434
Am I just missing permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, should not require permissions, but I got the same from my mobile, when not logged in to hf. Will investigate!
Added sample queries and radio button to select rank profile. |
If you're picky it means you care, so no worries :)
|
For a demo, I think the overall design is good. :) Fixing all the points above, I think it would be nice to also focus the user on the search field when the page loads. |
Fixed filling of sample queries. |
should we just merge and interate on this? |
I paused the live huggingface-demo, so I can remove the link pointing to that in the README first at least. |
Removed the link now. If noone else objects, I think we can merge. |
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Adds a sample app with a fastHTML-frontend.
All details should be in the README.
Deployed to https://huggingface.co/spaces/vespa-engine/fasthtml-vespa
Slack-msg if you need access. Intention is to make it public after merge.
The real test would be if someone else tried to deploy by following the README.
@lperry25 / @ldalves : Feel free to suggest some UI changes, if you see something that could be improved without adding too much complexity.
cc: @kkraune @jobergum