fix: fetch all git references in publish-cli workflow - MERGEOK #32287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esolitos
changed the title
bjormel
approved these changes
Aug 28, 2024
|
Please observe merge stops even for changes that don't affect the build because each merge to this repo triggers a new Vespa version build followed by all the system/performance/integration tests that take a few hours to run, this means that when a fix (for the issue that caused the merge stop) is merged, it may take longer to get it out, which makes the merge stop even longer :) |
|
Good to know, sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the "Publish CLI" action adds the
fetch-depth: 0option to the checkout github actions.Why
The deploy process does a check to see if there has been any changes in the codebase, but with a shallow clone it cannot do that, by setting
fetch-depth: 0the GH Action will fetch also all references.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.