Versatile group filter #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2016 07:05
but to dynamically generate a groupSearchFilter from a passed function with the user as argument Tested with both a fixed string as with a generated string
but to dynamically generate a groupSearchFilter from a passed function with the user as argument Tested with both a fixed string as with a generated string
| var searchFilter = self.opts.groupSearchFilter.replace(/{{dn}}/g, user[self.opts.groupDnProperty]); | ||
| var searchFilter = ''; | ||
|
|
||
| if ((typeof (self.opts.groupSearchFilter) === 'string')) { |
There was a problem hiding this comment.
Could you instead of this setup a function in the constructor, eg. something like this
if (typeof opts.groupSearchFilter === 'function') {
this.groupSearchFilter = opts.groupSearchFilter;
} else {
this.groupSearchFilter = function(user) {
return opts.groupSearchFilter.replace(...);
};
}Then the authentication function would just do var searchFilter = self.groupSearchFilter(user);. I think it would look cleaner that way.
but to dynamically generate a groupSearchFilter from a passed function with the user as argument Tested with both a fixed string as with a generated string
|
I have updated the pull request as per your comment. I have done it slightly different but I think it is in line with what you mentioned :-) |
|
Hello, |
|
Hello, Yes and then left to vacation and forgot the whole thing... Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in an issue some days ago, I have patched the groupfilter to allow for passing of a callback function next to the previously defined string. The first and only argument passed is the user object, which can be used to form a search filter string which needs to be returned.
I have tried out both the "old" functionality with a fixed string and tested it out with a dynamic filter: