Alert user to non-existent vote listener directory instead of throwing runtime exception #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime exception. Will continue to run, receiving votes and issuing VotifierListener events.
|
Thanks for the fix. |
blakeman8192
pushed a commit
that referenced
this pull request
Jun 4, 2012
Alert user to non-existent vote listener directory instead of throwing runtime exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blake:
I'm glad I was able to meet your needs. The first dance is always the hardest. I happened to notice a few posts about missing vote listener directories. I've addressed that issue in this patch. It verifies the listener directory's existence. If not found, users are warned and no vote listeners are loaded. Votifier continues to run in a degraded state, receiving votes and generating corresponding VotifierEvent events.
The patch is optional. I'll leave it up to you if you want to apply the patch or squirrel it away for the next major release.
Best,
Frelling