fix: perconas haproxy default cfg #1211
Conversation
|
ugh, I used to actually have a golang unit test that isn't running between the GHA/Jenkins/Zuul dance that would have caught this. Do you have time to port that test to Python instead or would you like me to if you don't have spare time @fitbeard ? |
|
@mnaser I need a working example to understand whole logic. Maybe you can create tests this time? When I have source for reference i'm very productive copy-cat'er:) |
|
@fitbeard there are btw, @mnaser i updated the current go unit test code to avoid version mismatching between image ref and cluster spec.CRVersion bf5ddfa |
|
/cherry-pick stable/2024.1 |
|
@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick stable/2023.2 |
|
@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick stable/2023.1 |
|
@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mnaser: new pull request created: #1988 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mnaser: new pull request created: #1989 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mnaser: new pull request created: #1990 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #1211 /assign mnaser
This is an automated cherry-pick of #1211 /assign mnaser
This is an automated cherry-pick of #1211 /assign mnaser
remove 1.22 from TestKubeconform test (node-feature-discovery uses grpc in probe which is available since 1.22) add a workaround values in TestKubeconform for loki chart skip CephFilesystemSubVolumeGroup kind for ceph chart fix oslo_db test expected values update TestImageExist test to support image tags without digest fix pxc test codes supplement placement chart value for database max_retries param depends-on: #1977 depends-on: #1211 depends-on: #1987 #1211 #1977 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com> Reviewed-by: Oleksandr K.
remove 1.22 from TestKubeconform test (node-feature-discovery uses grpc in probe which is available since 1.22) add a workaround values in TestKubeconform for loki chart skip CephFilesystemSubVolumeGroup kind for ceph chart fix oslo_db test expected values update TestImageExist test to support image tags without digest fix pxc test codes supplement placement chart value for database max_retries param depends-on: #1977 depends-on: #1211 depends-on: #1987 #1211 #1977 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com> Reviewed-by: Oleksandr K.
remove 1.22 from TestKubeconform test (node-feature-discovery uses grpc in probe which is available since 1.22) add a workaround values in TestKubeconform for loki chart skip CephFilesystemSubVolumeGroup kind for ceph chart fix oslo_db test expected values update TestImageExist test to support image tags without digest fix pxc test codes supplement placement chart value for database max_retries param depends-on: #1977 depends-on: #1211 depends-on: #1987 #1211 #1977 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com> Reviewed-by: Oleksandr K.
Since we are now using version 1.14.0 of the operator and default haproxy tag from it is also 1.14.0 we need to update haproxy config to
newversion. Without kubernetes resolver startup of haproxy pods takes much longer. And yes, it has nothing to do with crVersion: "1.13.0" from spec itself:)