Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add upgrade job #1384

Merged
merged 1 commit into from
Jul 5, 2024
Merged

chore: add upgrade job #1384

merged 1 commit into from
Jul 5, 2024

Conversation

ricolin
Copy link
Member

@ricolin ricolin commented Jun 18, 2024

Relate-to: #1068
Relate-to: #1282

Depends-On: #1408
Depends-On: #1409

@mnaser
Copy link
Member

mnaser commented Jun 18, 2024

@ricolin does it make sense to branch 2024.1 so we can make upgrade job from 2024.1 to main since thats a more supported upgrade route?

The other thing I wanted to bring up is what do you think of introducing a new upgrade pipeline, because if we run upgrade jobs on every commit, we doubled or CI time potentially (which is already kinda long tbh)...

@ricolin
Copy link
Member Author

ricolin commented Jun 18, 2024

@ricolin does it make sense to branch 2024.1 so we can make upgrade job from 2024.1 to main since thats a more supported upgrade route?
I trust your experience with upgrade:) and avoid cross multi-version upgrade sounds like a good plan too.

The other thing I wanted to bring up is what do you think of introducing a new upgrade pipeline, because if we run upgrade jobs on every commit, we doubled or CI time potentially (which is already kinda long tbh)...

Agree, +1 on a upgrade pipeline with comment_filter so we can do verify when we plan to before release or make it a perodic job.

Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to spend a bit of time thinking how we can accomplish this in a way where we have a separate pipeline probably or a periodic job.

roles/keycloak/tasks/main.yml Outdated Show resolved Hide resolved
@ricolin ricolin marked this pull request as ready for review June 19, 2024 14:18
zuul.d/jobs.yaml Outdated Show resolved Hide resolved
@ricolin
Copy link
Member Author

ricolin commented Jun 20, 2024

recheck

@ricolin ricolin force-pushed the add-upgrade-job branch from 34ffc26 to 5e8d8c4 Compare July 2, 2024 12:25
@ricolin
Copy link
Member Author

ricolin commented Jul 3, 2024

/cherry-pick stable/2024.1

@vexxhost-bot
Copy link
Collaborator

@ricolin: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ricolin
Copy link
Member Author

ricolin commented Jul 3, 2024

/cherry-pick stable/2023.2

@vexxhost-bot
Copy link
Collaborator

@ricolin: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ricolin
Copy link
Member Author

ricolin commented Jul 3, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@ricolin: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser mnaser added the gate label Jul 4, 2024
@atmosphere-ci atmosphere-ci bot merged commit 8356555 into main Jul 5, 2024
7 checks passed
@atmosphere-ci atmosphere-ci bot deleted the add-upgrade-job branch July 5, 2024 14:59
@vexxhost-bot
Copy link
Collaborator

@ricolin: new pull request created: #1519

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@ricolin: new pull request created: #1521

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@ricolin: new pull request created: #1522

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

atmosphere-ci bot pushed a commit that referenced this pull request Jul 8, 2024
This is an automated cherry-pick of #1384
/assign ricolin
atmosphere-ci bot pushed a commit that referenced this pull request Jul 8, 2024
This is an automated cherry-pick of #1384
/assign ricolin
atmosphere-ci bot pushed a commit that referenced this pull request Jul 8, 2024
This is an automated cherry-pick of #1384
/assign ricolin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants