Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue Live migration broken on 2023.1 #1493

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix issue Live migration broken on 2023.1 #1493

merged 2 commits into from
Jul 4, 2024

Conversation

yaguangtang
Copy link
Member

Fixes CLOUDOPS-233-live-migration-broken-on-2023-1

@yaguangtang yaguangtang self-assigned this Jul 3, 2024
@yaguangtang yaguangtang requested a review from mnaser July 3, 2024 17:31
mnaser
mnaser requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the comment above it and do like this

# NOTE(mnaser): ....

Instead use your username :)

@yaguangtang yaguangtang requested a review from mnaser July 4, 2024 01:27
@mnaser
Copy link
Member

mnaser commented Jul 4, 2024

/cherry-pick stable/2024.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Jul 4, 2024

/cherry-pick stable/2023.2

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Jul 4, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser mnaser added the gate label Jul 4, 2024
@yaguangtang yaguangtang enabled auto-merge (squash) July 4, 2024 13:26
@yaguangtang yaguangtang merged commit 2fab49f into main Jul 4, 2024
6 checks passed
@yaguangtang yaguangtang deleted the CLOUDOPS-233-live-migration-broken-on-2023-1 branch July 4, 2024 13:57
@vexxhost-bot vexxhost-bot mentioned this pull request Jul 4, 2024
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1496

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1497

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jul 4, 2024
Merged
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1498

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

atmosphere-ci bot pushed a commit that referenced this pull request Jul 4, 2024
@vexxhost-bot
[stable/2024.1] Fix issue Live migration broken on 2023.1 (#1496)
51ce77b 
This is an automated cherry-pick of #1493
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jul 4, 2024
@vexxhost-bot
[stable/2023.2] Fix issue Live migration broken on 2023.1 (#1497)
ee7574e 
This is an automated cherry-pick of #1493
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jul 4, 2024
@vexxhost-bot
[stable/2023.1] Fix issue Live migration broken on 2023.1 (#1498)
0f039a5 
This is an automated cherry-pick of #1493
/assign mnaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser mnaser approved these changes

Assignees

@yaguangtang yaguangtang

Labels
gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaguangtang @mnaser @vexxhost-bot