Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS to node exporter #1775

Merged
merged 20 commits into from
Aug 12, 2024
Merged

Add TLS to node exporter #1775

merged 20 commits into from
Aug 12, 2024

Conversation

mnaser
Copy link
Member

@mnaser mnaser commented Aug 11, 2024

  • Initial round of node-tls-sidecar
  • Fix image name
  • Added pod-tls-sidecar for node-exporter
  • The art of escaping Helm and Ansible
  • Fix configmap mount
  • Dance around Helm
  • Fix volume mount
  • Mount service token
  • Added RBAC
  • Fix role binding name
  • Switch node exporter to use TLS
  • Fix mount
  • Switch to VerifyClientCertIfGiven

@mnaser
Copy link
Member Author

mnaser commented Aug 12, 2024

/cherry-pick stable/2024.1

@mnaser
Copy link
Member Author

mnaser commented Aug 12, 2024

/cherry-pick stable/2023.2

@mnaser
Copy link
Member Author

mnaser commented Aug 12, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member Author

mnaser commented Aug 12, 2024

/cherry-pick stable/zed

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/zed in a new PR and assign it to you.

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser mnaser added the gate label Aug 12, 2024
@atmosphere-ci atmosphere-ci bot merged commit 2a165d3 into main Aug 12, 2024
7 checks passed
@atmosphere-ci atmosphere-ci bot deleted the node-exporter-pod-tls-sidecar branch August 12, 2024 03:04
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1776

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: #1775 failed to apply on top of branch "stable/2023.1":

Applying: Initial round of node-tls-sidecar
Applying: Fix image name
Applying: Added pod-tls-sidecar for node-exporter
Using index info to reconstruct a base tree...
M	roles/kube_prometheus_stack/defaults/main.yml
M	roles/kube_prometheus_stack/vars/main.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/kube_prometheus_stack/vars/main.yml
Auto-merging roles/kube_prometheus_stack/defaults/main.yml
Applying: The art of escaping Helm and Ansible
Applying: Fix configmap mount
Applying: Dance around Helm
Applying: Fix volume mount
Applying: Mount service token
Applying: Added RBAC
Applying: Fix role binding name
Applying: Switch node exporter to use TLS
Applying: Fix mount
Applying: Switch to VerifyClientCertIfGiven
Applying: Refactor to host certs
Using index info to reconstruct a base tree...
M	roles/kube_prometheus_stack/defaults/main.yml
M	roles/kube_prometheus_stack/vars/main.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/kube_prometheus_stack/vars/main.yml
Auto-merging roles/kube_prometheus_stack/defaults/main.yml
CONFLICT (content): Merge conflict in roles/kube_prometheus_stack/defaults/main.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0014 Refactor to host certs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new issue created for failed cherrypick: #1777

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: #1775 failed to apply on top of branch "stable/zed":

Applying: Initial round of node-tls-sidecar
Using index info to reconstruct a base tree...
M	roles/defaults/vars/main.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/defaults/vars/main.yml
CONFLICT (content): Merge conflict in roles/defaults/vars/main.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Initial round of node-tls-sidecar
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new issue created for failed cherrypick: #1778

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1779

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yaguangtang pushed a commit that referenced this pull request Aug 12, 2024
This is manual cherry-pick, Fixes #1778

Initial round of node-tls-sidecar
Fix image name
Added pod-tls-sidecar for node-exporter
The art of escaping Helm and Ansible
Fix configmap mount
Dance around Helm
Fix volume mount
Mount service token
Added RBAC
Fix role binding name
Switch node exporter to use TLS
Fix mount
Switch to VerifyClientCertIfGiven
yaguangtang pushed a commit that referenced this pull request Aug 12, 2024
Initial round of node-tls-sidecar
Fix image name
Added pod-tls-sidecar for node-exporter
The art of escaping Helm and Ansible
Fix configmap mount
Dance around Helm
Fix volume mount
Mount service token
Added RBAC
Fix role binding name
Switch node exporter to use TLS
Fix mount
Switch to VerifyClientCertIfGiven
atmosphere-ci bot pushed a commit that referenced this pull request Aug 12, 2024
This is an automated cherry-pick of #1775
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Aug 12, 2024
This is an automated cherry-pick of #1775
/assign mnaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants