[ATMOSPHERE-497] [stable/2024.1] chart: sync ovn with upstream #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for northd (#2010) because required the upstream patch rebased and also new versions include some fixes, i updated ovn chart version first and added liveness check in the patch for introducing kube-ovn Reviewed-by: Mohammed Naser <mnaser@vexxhost.com> Reviewed-by: Oleksandr K.
this error has been revealed by #1983 Good to have this go unit test in CI soon Moved to local patch https://review.opendev.org/c/openstack/openstack-helm-infra/+/893739/10
This was referenced Oct 25, 2024
atmosphere-ci bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2 fix #2001 Depends-On: #2028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.