feat: Support Flatcar OS #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add preKubeadmCommands for node name replacement Add flatcarDriver in poetry plugin list Enable required feature gate
Fix ignition ignoring error. Fix lint. Add comment about PATH overwrite in flatcar.
Remove default os in image build cmd
changed ignition config to match the one used by CAPO
1 task
CAPI expects a CA secret of type "cluster.x-k8s.io/secret" instead of "kubernetes.io/tls". Also, the "cluster.x-k8s.io/cluster-name" label has been added, containing the cluster's stack id.
stefan-chivu
force-pushed
the
flatcar-driver
branch
from
1fe298b
to
dfc1fe8
Compare
|
sadly it died on me right while i was debugging, but i was able to get into vnc using ngrok and found that it was complaining about an invalid/incorrect pound sign in the ignition config so it just died ( i'm restarting but this time i'll try to pull out the config it generated. |
|
|
ok, for some reason, it's getting plain ignition.. hold on... |
Out of curiosity, what does it get? |
|
5f7c715#diff-b74064dc7fb33b2c4232e9a38c8df0f8c59e996507abeb15478b0973e2e0a2d1R47 cloud-init, but that my bad :) |
|
success! it's just running sonobuoy now, if it's all good (which i believe it will be), i'll push up a later patch which will add the matrix back and will be able to merge this today. |
This was referenced Oct 2, 2023
This was referenced Dec 5, 2023
This was referenced Dec 15, 2023
This was referenced Mar 8, 2024
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #44
Adapted the aforementioned PR to contain the right ignition config and also modified the secret type used for the CA cert secret.
CAPI expects a CA secret of type "cluster.x-k8s.io/secret" instead of "kubernetes.io/tls". Also, the "cluster.x-k8s.io/cluster-name" label has been added for the secret resource, containing the cluster's stack id.