Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Win32Exception(error).Message for better exception messages in the drivers #34

Closed
1 task done
alexrp opened this issue Nov 28, 2021 · 1 comment
Closed
1 task done

Use new Win32Exception(error).Message for better exception messages in the drivers #34

alexrp opened this issue Nov 28, 2021 · 1 comment
Labels
area: drivers Issues related to the terminal drivers.
Milestone
v1.0

Comments

@alexrp
Copy link
Member

alexrp commented Nov 28, 2021 •
edited
Loading

Instead of just the GetLastError/errno value.

Partially blocked by:
@alexrp alexrp added os: darwin Issues that are specific to Darwin-based systems (e.g. macOS). os: linux Issues that are specific to Linux (Alpine, Debian, Fedora, etc). type: feature state: approved Enhancements and tasks that have been approved. area: drivers Issues related to the terminal drivers. labels Nov 28, 2021
@alexrp alexrp self-assigned this Nov 28, 2021
@alexrp alexrp changed the title Use strerror_r for better exception messages in the Unix drivers Use FormatMessage/strerror_r for better exception messages in the drivers Dec 1, 2021
@alexrp alexrp removed os: darwin Issues that are specific to Darwin-based systems (e.g. macOS). os: linux Issues that are specific to Linux (Alpine, Debian, Fedora, etc). labels Dec 1, 2021
@alexrp
Copy link
Member Author

alexrp commented Dec 1, 2021

Turns out we can just do new Win32Exception(err).Message on all platforms (err being the return value of e.g. Marshal.GetLastPInvokeError).

@alexrp alexrp changed the title Use FormatMessage/strerror_r for better exception messages in the drivers Use new Win32Exception(error).Message for better exception messages in the drivers Dec 1, 2021
@alexrp alexrp added state: blocked Issues that are blocked on some other issue or work. and removed state: approved Enhancements and tasks that have been approved. labels Dec 1, 2021
alexrp added a commit that referenced this issue Dec 1, 2021
@alexrp
Use Win32Exception.Message in WindowsTerminalUtility.ThrowIfUnexpected.
f298260 
Part of #34.
alexrp added a commit that referenced this issue Dec 1, 2021
@alexrp
Use Win32Exception.Message in Unix drivers.
29f7c07 
Part of #34.
@alexrp alexrp closed this as completed in 1f965c8 Dec 9, 2021
@alexrp alexrp added state: resolved and removed state: blocked Issues that are blocked on some other issue or work. labels Dec 9, 2021
@alexrp alexrp added this to the v1.0 milestone Dec 20, 2021
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: drivers Issues related to the terminal drivers.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp