Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cult 2020 Rework #1: Seer #27950

Merged

Conversation

DeityLink
Copy link
Collaborator

@DeityLink DeityLink commented Oct 4, 2020

image

It's been a few months since I shared my views on how to rework cult #26941 and now that I'm finally done with xenoarch, centcom orders, and feeling sick despite not having covid according to the test results, I'm finally ready to focus fully on cult for the next few months.

Unlike Cult 3.0 that came out all at once, this rework will come in many smaller parts, allowing the easy-to-review/implement stuff to get taken care of first, especially since much of it isn't incompatible with Cult 3.0 as it currently works. Such as this Seer rework.

Well it's not so much a rework as it gives it a new functionality that may also become its main use from now on.
image

🆑

  • rscadd: Cult 2020: Seer runes and talismans now let cultists figure out the propension of nearby crew members to accept or refuse conversion, allowing cultists to target people who actually want to be cultists and reducing frustration for everyone involved. Implanted crew members appear as unconvertable (as they will be once Conversions are reworked next).
  • tweak: Cult 2020: Seer talisman duration increased from 8 seconds to 1 minute.

@PrimeDSS13
Copy link
Contributor

all my cultists hate boxers
good PR

if (client)
acceptance = get_role_desire_str(client.prefs.roles[CULTIST])

for(var/obj/item/weapon/implant/loyalty/I in src)
Copy link
Contributor

@drawsstuff drawsstuff Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀👀👀, loyalty implants blocking conversion? Real shit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read the damn doc https://docs.google.com/document/d/1e49TxEMFdzAwpvIy6alBgYrytWfAo5F-O5A62PW2KvY/edit#

It won't do it in this PR but it might in the next one, since I want to tackle conversion as early as possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the doc and liked what I read. This is just too good to be true seeing it in action. Bless you Deity.

@ancientpower
Copy link
Contributor

downboated, how am I supposed to dab on culties by boxing if they can see I have cult set to never?

@drawsstuff
Copy link
Contributor

downboated, how am I supposed to dab on culties by boxing if they can see I have cult set to never?

Set your cult preference to choice to inspire false hope in their hearts, box anyways

@DeityLink
Copy link
Collaborator Author

@Allspice can do
image

@DeityLink
Copy link
Collaborator Author

DeityLink commented Oct 4, 2020

Added a debug-only HUD that lets admins check convertibility.

Also fixed at the same time AntagHUD not going away when Disabled.

@DeityLink
Copy link
Collaborator Author

DeityLink commented Oct 4, 2020

And also fixed antag HUD icons appearing bellow mechas lol Moved to another PR.

@mrflarg
Copy link

mrflarg commented Oct 5, 2020

'ate gult 3 but this seems like a weird way to fix it, incorporating further the meta-game of if someone has their setting set to no.
Would it not be possible to just have cult only fire when there is a chaplain and make those that convert to the chaplain's religion unconvertable? It would make a lot more sense, it would also fulfill the chaplain role more.
It would mean removing the Christianity automatic thing, but not like we ever get a chaplain that actually tries to preach or hold sermons as a Christian.

@DeityLink
Copy link
Collaborator Author

DeityLink commented Oct 5, 2020

Would it not be possible to just have cult only fire when there is a chaplain

Having an antag role, a team one nonetheless rely on the presence and skill of a single job whose purpose is pure RP 99% of the time is bad design. We'd go back to Cult 2 days of chaplains getting silently taken out early into the round and then sec complaining of being unable to deconvert players without a chaplain around. The chaplain no longer being necessary in the upcoming deconversion update is also to prevent having this single point of failure that often ends up making rounds way worse.
The chaplain has a role already, an RP one just like the Clown and Mime. He can also help fight the cult by both producing more holy water and incense. Fighting the cult directly is not part of his job application, we're not in Wh40k here.

Also being immune to conversion just from having a religion doesn't make sense to me. You could argue that the chaplain had special training, but random Assistant #239 did not.

@mrflarg
Copy link

mrflarg commented Oct 5, 2020

Would it not be possible to just have cult only fire when there is a chaplain

Having an antag role, a team one nonetheless rely on the presence and skill of a single job whose purpose is pure RP 99% of the time is bad design. We'd go back to Cult 2 days of chaplains getting silently taken out early into the round and then sec complaining of being unable to deconvert players without a chaplain around. The chaplain no longer be necessary for the upcoming deconversion update is also to prevent having this single point of failure that often ends up making rounds way worse.
The chaplain has a role already, an RP one just like the Clown and Mime. He can also help fight the cult by both producing more holy water and incense. Fighting the cult directly is not part of his job application, we're not in Wh40k here.

Also being immune to conversion just from having a religion doesn't make sense to me. You could argue that the chaplain had special training, but random Assistant #239 did not.

I wasn't being very clear, I just meant for the chaplain to purely act as a catalyst for cult, so that as I proposed conversions should conflict with if the convertee is religious or not, and not the meta checklist.
The security level and so on should still exist.
I just don't like the idea of giving in to a metagame of if someone has their magic checkbox ticked no.

And what you said in the discord.

  • Just have nobody ever pick chaplain ever again and cult is gone forever

I can't see this happening, people always want to try gimmicks out. But I do agree that it will cause fewer people to play chaplain knowing there is a risk of their round being gunked to shit.

  • If someone picks chaplain because they want to see the cult then they're playing the one role that CANNOT become cult

Chaplains can not be converted at the moment or am I wrong? I don't see how this is an issue unless I am misreading.

@tuypo1
Copy link
Contributor

tuypo1 commented Oct 5, 2020

I feel like it should just be a free toggle rather than a spell you have to put effort into but it is a step in the right direction for sure

@DeityLink
Copy link
Collaborator Author

@mrflarg even moreso then, your suggestions are unrelated to this PR. I'll continue this conversation on Discord to not bloat this comment section further.

@KingofHONK
Copy link
Contributor

cant wait to SEER this in action

desc = "See the invisible, the dead, the concealed. If you give them a writing sheet, they may relay a message to you."
desc_talisman = "For a few seconds, you may see the invisible, the dead, the concealed. If you give them a writing sheet, they may relay a message to you."
desc = "See the invisible, the dead, the concealed, as well as the living's propension to serve our agenda."
desc_talisman = "For a whole minute, you may see the invisible, the dead, the concealed, as well as the living's propension to serve our agenda."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and the propensity of the living to serve our agenda" is more natural language

Act_restriction = CULT_ACT_I
invocation = "Rash'tla sektath mal'zua. Zasan therium viortia."
rune_flags = RUNE_STAND
talisman_uses = 5
word1 = /datum/runeword/blood_cult/see
word2 = /datum/runeword/blood_cult/hell
word3 = /datum/runeword/blood_cult/join
page = "This rune grants you the ability to see the invisible, including observers and concealed runes and structures. The talisman version has 5 uses, which grant you the ability for 8 seconds each. Remember that runes can still be activated while they are concealed! "
page = "This rune grants you the ability to see the invisible, including observers and concealed runes and structures. The talisman version has 5 uses, which grant you the ability for an entire minute each, allowing you as well to see how likely each crew members are to accept conversion. Remember to activate the talisman where no one can hear you first. Remember also that runes can still be activated while they are concealed! "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entire seems extraneous
"each crew member is" to accept conversion, use "is" for singular

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this whole block of text is awkwardly phrased, with two remembers and separating the part about willingness, just rewrite it

This rune grants the ability to see invisible ghosts, runes, and structures. It also reveals the willingness of crew members to accept conversion. You can activate runes while they are concealed. In talisman form, it has five uses and lasts for a minute each. Activate the talisman before moving into a public.

@@ -1743,12 +1743,11 @@ var/list/blind_victims = list()
var/mob/living/M = activator
M.see_invisible_override = SEE_INVISIBLE_OBSERVER
M.apply_vision_overrides()
to_chat(M, "<span class='notice'>As the talisman disappears into dust, you find yourself able to see through the gaps in the veil. You can see and interact with the other side, for a few seconds.</span>")
to_chat(M, "<span class='notice'>As the talisman disappears into dust, you find yourself able to see through the gaps in the veil. You can see and interact with the other side for a minute, as well as see the living's likelyhood of accepting conversions.</span>")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likelihood

client/proc/toggle_convertibles()
set name = "Toggle Convertibles HUD (Cult 3.0+)"
set category = "Debug"
set desc = "Displays a marker over crew members showing their propension to get converted."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propensity really is more common in English, propension is archaic

set desc = "Displays a marker over crew members showing their propension to get converted."

var/mob/dead/observer/adminmob = mob
if (!isobserver(adminmob))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about no adminghost check, do we really want to make it publicly visible everyone's antag prefs at all times?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb only appears in the Debug tab and is only given to admins with +DEBUG. Are there exploits that let non-admins use it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have sanity but if people have a way to call adminverbs we have a bigger issue than this I suppose, since a lot of oldcode stuff has no sanity

@Kurfursten
Copy link
Collaborator

Codewise this is fine but the language is a bit off

@DeityLink
Copy link
Collaborator Author

Applied Kurf's suggested text fixes.

@Kurfursten Kurfursten merged commit 73b8f94 into vgstation-coders:Bleeding-Edge Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants